Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octopus: mgr/dashboard: Fix for alert notification message being undefined #40589

Merged
merged 1 commit into from Apr 27, 2021
Merged

octopus: mgr/dashboard: Fix for alert notification message being undefined #40589

merged 1 commit into from Apr 27, 2021

Conversation

nizamial09
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/50070

backport of #40332
parent tracker: https://tracker.ceph.com/issues/49342

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@nizamial09 nizamial09 requested a review from a team as a code owner April 5, 2021 06:27
@nizamial09 nizamial09 requested review from pereman2 and Waadkh7 and removed request for a team April 5, 2021 06:27
@nizamial09 nizamial09 added this to the octopus milestone Apr 5, 2021
@nizamial09
Copy link
Member Author

jenkins test make check

@nizamial09
Copy link
Member Author

jenkins test api

@nizamial09 nizamial09 changed the title octopus: mgr/dashboard: Fix for alert notification message being undefined octopus: mgr/dashboard: Fix for alert notification message being undefined Apr 6, 2021
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09 nizamial09 requested a review from a team April 12, 2021 17:34
@nizamial09 nizamial09 requested a review from a team as a code owner April 12, 2021 17:34
@tchaikov
Copy link
Contributor

i think most of cephadm test failures are caused by https://tracker.ceph.com/issues/49293

@nizamial09
mgr/dashboard: Fix for alert notification message being undefined
74299ff 
Prometheus alert notification message in the dashboard always comes up
as undefined. Its because we were showing the alert.summary instead of
alert.description for displaying the message. I couldn't find the
summary field in the ceph_default_alerts.yml file. So removed all the
Summary fields from the dashboard code.

Fixes: https://tracker.ceph.com/issues/49342
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 2921b2e)
@nizamial09
Copy link
Member Author

i think most of cephadm test failures are caused by https://tracker.ceph.com/issues/49293

Thanks @tchaikov

@idryomov idryomov changed the base branch from octopus to octopus-saved April 20, 2021 15:57
@idryomov idryomov changed the base branch from octopus-saved to octopus April 20, 2021 15:57
@nizamial09
Copy link
Member Author

jenkins test dashboard

@avanthakkar
Copy link
Contributor

jenkins test api

@tchaikov
Copy link
Contributor

jenkins test api

@nizamial09 nizamial09 added this to In progress in Dashboard via automation Apr 26, 2021
@nizamial09 nizamial09 moved this from In progress to Ready-to-merge in Dashboard Apr 26, 2021
@tchaikov tchaikov merged commit f12f213 into ceph:octopus Apr 27, 2021
Dashboard automation moved this from Ready-to-merge to Done Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@Waadkh7 Waadkh7 Waadkh7 approved these changes

@pereman2 pereman2 Awaiting requested review from pereman2

@callithea callithea Awaiting requested review from callithea

Assignees
No one assigned
Labels
dashboard
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
octopus
5 participants
@nizamial09 @tchaikov @avanthakkar @alfonsomthd @Waadkh7