osd: Revert "osd: Try other PGs when reservation failures occur" #40623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-ojha
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
since https://tracker.ceph.com/issues/49868 is showing up in almost every rados run, makes sense to revert the relevant commits and merge back with the fix.
@ronen-fr nit: you can add the reason for reverting this change in the commit message as well
This reverts commit 08c3ede. Due to https://tracker.ceph.com/issues/49868 Should be reinstated once that bug is solved. See tracker comments for analysis and suggested fixes. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
force-pushed
the
wip-ronenf-revert-40077
branch
from
d295e10
to
c57731d
Compare
Done |
neha-ojha
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to https://tracker.ceph.com/issues/49868
Should be reinstated once that bug is solved. See tracker comments for analysis
and suggested fixes.