mon: load stashed map before mkfs monmap #40660
Conversation
After mkfs the store may not yet contain monmap:last_committed but might be respawning after setting mon_sync:temp_newer_monmap. Load that stashed map before falling back to the mkfs:monmap. Fixes: https://tracker.ceph.com/issues/50230 Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
|
I tested this change -- it solves our bootstrapping problem. |
There was a problem hiding this comment.
this change should work. but i think it might be better if we could make the "mon_sync:temp_newer_monmap" machinery more explicit. it was introduced back in https://tracker.ceph.com/issues/44076, and its purpose was to break the respawn loop of the monitor whose addresses changes in the latest map by overriding the osdmap before the monitor bootstraps using the wrong address.
i will try to come up with a cleanup to make the override more explicit. and probably remove the "mon_sync:temp_newer_monmap" value once the monitor is bootstrapped with the correct rank and address.
Correct, and that previous fix only covered the case where the mon db was existing for awhile (i.e. monmap:last_committed exists). |
After mkfs the store may not yet contain monmap:last_committed but
might be respawning after setting mon_sync:temp_newer_monmap.
Load that stashed map before falling back to the mkfs:monmap.
Fixes: https://tracker.ceph.com/issues/50230
Signed-off-by: Dan van der Ster daniel.vanderster@cern.ch