Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: rgw: return ERR_NO_SUCH_BUCKET early while evaluating bucket policy #40668

Merged
merged 1 commit into from Apr 9, 2021
Merged

nautilus: rgw: return ERR_NO_SUCH_BUCKET early while evaluating bucket policy #40668

merged 1 commit into from Apr 9, 2021

Conversation

smithfarm
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/50233

backport of #26569
parent tracker: https://tracker.ceph.com/issues/38420

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@theanalyst @smithfarm
rgw: return ERR_NO_SUCH_BUCKET early while evaluating bucket policy
41d98b0 
Right now we create a ERR_NO_SUCH_BUCKET ret code but continue further
processing. Since this ret code isn't returned at any stage we end up creating a
bucket instance anyway which shouldn't happen and then succeeding the client
call in cases like put bucket versioning. Return an error code early in these
cases

Fixes: http://tracker.ceph.com/issues/38420
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit cf66a6d)
@smithfarm smithfarm added this to the nautilus milestone Apr 8, 2021
@smithfarm smithfarm added the rgw label Apr 8, 2021
@smithfarm smithfarm mentioned this pull request Apr 8, 2021
Closed
3 tasks
mattbenjamin
mattbenjamin approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm
Copy link
Contributor Author

smithfarm commented Apr 8, 2021 •
edited

We seem to have a transient make check issue in nautilus:

make[3]: *** [src/test/rgw/CMakeFiles/unittest_rgw_dmclock_scheduler.dir/build.make:63: src/test/rgw/CMakeFiles/unittest_rgw_dmclock_scheduler.dir/test_rgw_dmclock_scheduler.cc.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:19800: src/test/rgw/CMakeFiles/unittest_rgw_dmclock_scheduler.dir/all] Error 2

(Looks like a problem with the dmclock submodule or with boost...)

@smithfarm
Copy link
Contributor Author

jenkins test make check

@smithfarm
Copy link
Contributor Author 

The following tests FAILED:
	124 - unittest_journal (Timeout)

@smithfarm
Copy link
Contributor Author

jenkins test make check

@smithfarm smithfarm added nautilus-batch-1 nautilus point releases needs-qa labels Apr 8, 2021
@yuriw yuriw merged commit 2436fbf into ceph:nautilus Apr 9, 2021
@smithfarm smithfarm deleted the wip-50233-nautilus branch April 9, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbenjamin mattbenjamin mattbenjamin approved these changes

@ivancich ivancich Awaiting requested review from ivancich

Assignees
No one assigned
Labels
nautilus-batch-1 nautilus point releases needs-qa rgw wip-yuri7-testing
Projects
None yet
Milestone
nautilus
4 participants
@smithfarm @mattbenjamin @yuriw @theanalyst