mgr/orchestractor: rgw realm and zone flags must both be provided #40735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
approved these changes
Apr 9, 2021
|
Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
Daniel-Pivonka
force-pushed
the
orchvalidatergwspec
branch
from
1aa068f
to
c0803f8
Compare
jmolmo
requested changes
Apr 12, 2021
adk3798
approved these changes
Apr 13, 2021
jmolmo
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if only realm was provided rgw runs in default(nonmultisite) mode which is not the expected behavior.
if only zone was provided the daemons would crash. error was obvious in the containers logs but user would have had to go looking there to figure it out.
adding check that both flags are provided and error if not so the user is clearly aware of the problem.
Fixes: https://tracker.ceph.com/issues/50267
Signed-off-by: Daniel Pivonka dpivonka@redhat.com