octopus: rgw/notification: support GetTopicAttributes API #40754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: https://tracker.ceph.com/issues/46296 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com> (cherry picked from commit 3906884) Conflicts: PendingReleaseNotes src/rgw/rgw_rest_pubsub.cc - RGWHandler_REST_PSTopic_AWS::authorize function definition looks different in octopus
smithfarm
commented
Apr 10, 2021
| encode_json("EndpointArgs", push_endpoint_args, &f); | ||
| encode_json("EndpointTopic", arn_topic, &f); | ||
| encode_json("HasStoredSecret", stored_secret, &f); | ||
| encode_json("Persistent", persistent, &f); |
There was a problem hiding this comment.
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_pubsub.cc: In member function 'std::string rgw_pubsub_sub_dest::to_json_str() const':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_pubsub.cc:405:29: error: 'persistent' was not declared in this scope
405 | encode_json("Persistent", persistent, &f);
| ^~~~~~~~~~
make[3]: *** [src/rgw/CMakeFiles/rgw_common.dir/build.make:860: src/rgw/CMakeFiles/rgw_common.dir/rgw_pubsub.cc.o] Error 1
|
non-trivial to backport |
|
created: #40812 to resolve the above conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/48462
backport of #38171
parent tracker: https://tracker.ceph.com/issues/46296
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh