octopus: crush/CrushLocation: do not print logging message in constructor #40791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not use logging facility in constructor, as CephContext::_log is set after CephContext::crush_location is created in constructor of CephContext. Fixes: https://tracker.ceph.com/issues/50047 Signed-off-by: Alex Wu <notmycupoftea@163.com> (cherry picked from commit 68812a2)
tchaikov
approved these changes
Apr 11, 2021
smithfarm
requested review from
alfonsomthd and
nizamial09
and removed request for
a team
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/50120
backport of #40457
parent tracker: https://tracker.ceph.com/issues/50047
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh