cephfs-mirror: incremental sync #40831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshankar
force-pushed
the
wip-cephfs-mirror-incremental-sync
branch
2 times, most recently
from
c12519f
to
06f677c
Compare
|
Build failures are due to requirement of PR #40810. |
|
vshankar
force-pushed
the
wip-cephfs-mirror-incremental-sync
branch
2 times, most recently
from
b7c0246
to
f9487d9
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
... and rebased again |
vshankar
force-pushed
the
wip-cephfs-mirror-incremental-sync
branch
from
f9487d9
to
6428018
Compare
|
rebase and updated -- also included changes to sync file mode. |
vshankar
force-pushed
the
wip-cephfs-mirror-incremental-sync
branch
from
6428018
to
127779c
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Purpose of this xattr is to identify if the "next" snapshot to be synchronized can be incrementally transferred. Value of the xattr is the snap-id of a snapshot in the primary cluster (for a given directory root). CephFS mirror daemon sets this xattr on the directory root once the data for a snapshot is synchronized, thereby signifying that the data under this directory root is the data of the snapshot identified by the snap-id value. This allows the mirror daemon to use the much efficient selective synchronzation (based on mtime/ctime) by scanning the two snapshots locally and only transferring the inodes that have changed. Signed-off-by: Venky Shankar <vshankar@redhat.com>
…any remote (sub)directory Right now, the only path to cleanup (purge) is the remote file system directory root (for configured snapshot directories). With incremental sync, we would need the ability to cleanup selective directories under configured snapshot directories. Furthermore, the path passed to the function ise used to checking if the mirror daemon needs to backoff due to mirroring being disabled, daemon shutdown etc. So, adjust the function prototype to accept the directory root and the relative path to be cleaned up under this directory. Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Use incremental transfer when the data on the remote file system for a given directory root is belongs to the snapshot which can be used for local comparison. Files are chosen based on mtime changes. Signed-off-by: Venky Shankar <vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Fixes: http://tracker.ceph.com/issues/49939 Signed-off-by: Venky Shankar <vshankar@redhat.com>
vshankar
force-pushed
the
wip-cephfs-mirror-incremental-sync
branch
from
127779c
to
da9788a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires PR #40810 to build and use.
Snap data is incrementally transferred to remote file system based on mtime/ctime differences. This does away with cleaning up remote file system data on each snap sync. Whenever possible, changes are identified by scanning local snapshot pair. On the other hand, when last synced ("previous") snapshot cannot be used for comparison, changes are identified by comparing "current" snapshot data to remote filesystem directory root (for the directory in question).
Also, this relies to *at() libcephfs APIs to ensure correctness of the snapshot being synchronized FTW.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox