Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octopus: mgr/dashboard: improve telemetry opt-in reminder notification message #40894

Merged
merged 1 commit into from Apr 27, 2021

Conversation

Waadkh7
Copy link

@Waadkh7 Waadkh7 commented Apr 16, 2021

backport tracker: https://tracker.ceph.com/issues/50349


backport of #40348
parent tracker: https://tracker.ceph.com/issues/49606

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

Added activition button and linked the word telemetry to telemetry documentation

Fixes: https://tracker.ceph.com/issues/49606
(cherry picked from commit 527d912)
Signed-off-by: Waad Alkhoury <walkhour@redhat.com>
@Waadkh7 Waadkh7 requested a review from a team as a code owner April 16, 2021 17:21
@Waadkh7 Waadkh7 requested review from alfonsomthd and pereman2 and removed request for a team April 16, 2021 17:21
@Waadkh7 Waadkh7 added this to the octopus milestone Apr 16, 2021
@Waadkh7
Copy link
Author

Waadkh7 commented Apr 19, 2021

jenkins retest this please

@tchaikov
Copy link
Contributor

INFO: pip is looking at multiple versions of ceph to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install -r requirements-lint.txt (line 10) and -r requirements-lint.txt (line 2) because these package versions have conflicting dependencies.

The conflict is caused by:
    flake8 3.7.8 depends on pycodestyle<2.6.0 and >=2.5.0
    autopep8 1.5.6 depends on pycodestyle>=2.7.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies
[ 13%] Building CXX object src/common/CMakeFiles/common-common-objs.dir/Formatter.cc.o
[ 13%] Built target cls_refcount_client
Collecting virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0
  CC eal_common_uuid.o
[ 13%] Built target mgr-insights-venv
  Using cached virtualenv-20.4.3-py2.py3-none-any.whl (7.2 MB)
make[3]: *** [src/pybind/mgr/dashboard/CMakeFiles/mgr-dashboard-venv.dir/build.make:61: mgr-dashboard-virtualenv/bin/activate] Error 1
make[3]: *** Deleting file 'mgr-dashboard-virtualenv/bin/activate'
make[2]: *** [CMakeFiles/Makefile2:7466: src/pybind/mgr/dashboard/CMakeFiles/mgr-dashboard-venv.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....

@idryomov idryomov changed the base branch from octopus to octopus-saved April 20, 2021 13:12
@idryomov idryomov requested a review from a team as a code owner April 20, 2021 13:12
@idryomov idryomov changed the base branch from octopus-saved to octopus April 20, 2021 13:12
@Waadkh7
Copy link
Author

Waadkh7 commented Apr 23, 2021

jenkins retest this please

@Waadkh7 Waadkh7 added this to Reviewer approved in Dashboard Apr 26, 2021
@epuertat epuertat merged commit 724d6ea into ceph:octopus Apr 27, 2021
Dashboard automation moved this from Reviewer approved to Done Apr 27, 2021
@epuertat epuertat deleted the wip-50349-octopus branch April 27, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
5 participants