common/options: fix several out of date defaults and options added during yaml conversion #40896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
…the yaml conversion Presumably git didn't complain during a rebase because the whole file was removed. Signed-off-by: Josh Durgin <jdurgin@redhat.com>
…onversion These were updated two years ago in 303d425 Signed-off-by: Josh Durgin <jdurgin@redhat.com>
…ml conversion This was set higher by 2093c88 Signed-off-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
|
I did not verify all the other fields, but type/presence/default values all match the old options.cc now. |
These were removed in a5f9ca1 Signed-off-by: Josh Durgin <jdurgin@redhat.com>
|
This fixes https://tracker.ceph.com/issues/50368. |
tchaikov
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these got reset to old values (or old options were added back when they didn't exist anymore).
The ones most likely to have caused issues are the bluestore cache options.