objecter shutdown races with msg dispatch #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a tiny cleanup. Signed-off-by: Josh Durgin <josh.durgin@inktank.com> (cherry picked from commit 1feba20)
shutdown() resets initialized to 0, but we can still receive messages after this point, so fix message handlers to skip messages in this case instead of asserting. Also read initialized while holding Objecter::rwlock to avoid races where e.g. handle_osd_map() checks initialized -> 1, continues, shutdown() is called, sets initialized to 0, then handle_osd_map() goes about its business and calls op_submit(), which would fail the assert(initialized.read()) check. Similar races existed in other message handlers which change Objecter state. The Objecter is not destroyed until after its Messenger in the MDS, OSD, and librados, so this should be safe. Fixes: #9617 Backport: giant Signed-off-by: Josh Durgin <josh.durgin@inktank.com> (cherry picked from commit e506f89) Conflicts: src/osdc/Objecter.cc context changed: Objecter::tick() did not have assert(initialized.read())
|
SUCCESS: the output of run-make-check.sh on centos-7 for 3b35c5d is http://paste2.org/OegU15UB |
Sent from
ghost
pushed a commit
that referenced
this pull request
Mar 22, 2015
objecter shutdown races with msg dispatch Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>
ghost
merged commit 
ghost
mentioned this pull request
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
May 25, 2015
Fixes: ceph#4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Jun 15, 2015
Fixes: ceph#4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Jun 23, 2015
Fixes: ceph#4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Aug 18, 2015
Fixes: ceph#4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
added a commit
to rzarzynski/ceph
that referenced
this pull request
Aug 20, 2015
Fixes: ceph#4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
yehudasa
pushed a commit
that referenced
this pull request
Aug 27, 2015
Fixes: #4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
branch-predictor
pushed a commit
to branch-predictor/ceph
that referenced
this pull request
Sep 30, 2015
Fixes: ceph#4096 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/9617