mgr/dashboard: disable NFSv3 support in dashboard

[votdev]

The v3 checkbox is disabled. The v3 checkbox is unchecked and v4 is checked by default. The form can not be submitted if both protocols are unchecked.

Fixes: https://tracker.ceph.com/issues/49718
Related to: #40154

According to #40154 (comment) there is a bigger refactoring ongoing, but the issue must be backported to Octopus, so a simple cleanup would be easier to backport.

Signed-off-by: Volker Theile vtheile@suse.com

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[epuertat]

jenkins test dashboard

[epuertat]

LGTM! Thanks @votdev !

[epuertat]

@alfonsomthd as you've been recently taking care of NFS stuff, what do you think about this approach?

[votdev]

The last commit removes the disabled property from the v4 checkbox. This way it is still possible to edit existing setups without forcing the export to support v4.
New NFS exports can not select v3, and the form can't be submitted if v4 is not checked.
Additionally a new unit test has been added to ensure this behavior.

[votdev]

jenkins test dashboard

[alfonsomthd]

@alfonsomthd as you've been recently taking care of NFS stuff, what do you think about this approach?

I'm OK with it.

[alfonsomthd]

@votdev I see that before checking NFSv4, NFSv3 is greyed out to indicate not selectable, but after unchecking andd seeing required red color, when you check again NFSv4 then NFSv3 visually appears as selectable (the text is not greyed out):
Step 1:

Step 2:

[alfonsomthd]

#41081 (comment)

[votdev]

@votdev I see that before checking NFSv4, NFSv3 is greyed out to indicate not selectable, but after unchecking andd seeing required red color, when you check again NFSv4 then NFSv3 visually appears as selectable (the text is not greyed out):
Step 1:

Step 2:

I can not confirm this behavior with Firefox 88.0 (creating a new export) and Chrome 90.0.4430.93 (editing an existing export; the second window in the video).

[alfonsomthd]

I can not confirm this behavior with Firefox 88.0 (creating a new export) and Chrome 90.0.4430.93 (editing an existing export; the second window in the video).

Ceph.mp4

BTW I see in your video that "Create NFS Export" button is placed before "Cancel" button but in master is currently on reverse...

[alfonsomthd]

@votdev Maybe the issue is related to validation logic and not related to this PR.

[votdev]

@votdev Maybe the issue is related to validation logic and not related to this PR.

Indeed, that's caused by the validation logic. I think we should ignore this little visual issue, otherwise some more code changes are required, and i really want to keep such changes low to do not get unexpected side effects.