-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: fix ESOCKETTIMEDOUT E2E failure #41104
mgr/dashboard: fix ESOCKETTIMEDOUT E2E failure #41104
Conversation
6ee7802
to
b32017e
Compare
b32017e
to
b652b6a
Compare
b652b6a
to
f58ffb6
Compare
I think we don't need to make changes in script in order to change the responseTimeout. As when we run |
f58ffb6
to
0f71418
Compare
I don't understand why we do this in afterEach hook ? Shouldn't we instead call something like |
Try to run the whole suite without the afterEach hook to check if it's not needed anymore. |
Yes..but I'm sure abt why we redirect to 403 page..I understand atleast why we should redirect (I think it's following best practices in order to clean up the state generated by the current test(s)), but not sure about 403 page in specific..can't we do instead logout? But in any case the fix should remain the same i.e. to increase |
0f71418
to
0617400
Compare
jenkins test dashboard |
0617400
to
5fed826
Compare
5fed826
to
1159d82
Compare
Fixes: https://tracker.ceph.com/issues/49828 Signed-off-by: Avan Thakkar <athakkar@redhat.com>
1159d82
to
bf4894f
Compare
jenkins test dashboard |
@@ -7,6 +7,7 @@ | |||
"supportFile": "cypress/support/index.ts", | |||
"video": false, | |||
"defaultCommandTimeout": 120000, | |||
"responseTimeout": 45000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we need to increase the response time from 30 secs to 45 secs? Are we talking about HTTP requests? If that's the case I feel that the issue will be somewhere else :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we need to increase the response time from 30 secs to 45 secs? Are we talking about HTTP requests? If that's the case I feel that the issue will be somewhere else :/
I followed this cypress-io/cypress#7062 (comment) and I think it's same issue for us. Somehow cy.request()
is taking some more time in cypress browser env so cy.visit()
after it is failing to load(also I tried removing that afterEach hook(which isn't consider best practice) but it's somehow broke some tests).
Increasing responseTimeout may help resolve the e2e failures with
cy.visit()/cy.request() failed to load error
, as it's considered the most accepted solution here cypress-io/cypress#7062 too, which happens only in CI jobs. The top failure jobs in last 3 months have the same error of timeout/failed to load.Example error message :
cy.request() timed out waiting 30000ms for a response from your server.
Fixes: https://tracker.ceph.com/issues/49828
Signed-off-by: Avan Thakkar athakkar@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox