mgr/cephadm: add timeout when removing iscsi gateway.conf #41181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the file in mgr/cephadm are getting changed every time I want to run the mgr tox tests to check changes and it's inconvenient to have to check the files out every time Signed-off-by: Adam King <adking@redhat.com>
We already catch TimeoutExpired exceptions here but we don't actually specify a timeout Signed-off-by: Adam King <adking@redhat.com>
tests that remove iscsi daemons use subprocess.run to make a call to rados to clear out the gateway.conf. We don't want the tests to actually make that call. Signed-off-by: Adam King <adking@redhat.com>
jmolmo
approved these changes
May 6, 2021
Daniel-Pivonka
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already catch TimeoutExpired exceptions here but we don't
actually specify a timeout
Also, added mocking the subprocess.run call in tests that remove iscsi daemons and a few lines that are being automatically changed by autopep8 whenever I run mgr tox locally.
Signed-off-by: Adam King adking@redhat.com
Follow-up on #40313
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox