Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM: TOO RISKY] nautilus: osd/ECBackend: don't remove in-flight backfill when missing is not primary #41293

Closed
wants to merge 4 commits into from

Commits on May 12, 2021

  1. osd/ECBackend: don't remove in-flight backfill when missing is not pr…

    …imary
    
    This is a direct commit to nautilus branch to recreate the
    behaviour we have post-nautilus, after refactoring made in
    8a8947d, which seems to be
    correct.
    
    The in-flight backfill prevents updating of "backfill complete"
    position, which remains on the object before the missing oid. So
    when pg is re-peered it retries backfill from this position
    instead of entering the clean state.
    
    Fixes: https://tracker.ceph.com/issues/50747
    Signed-off-by: Mykola Golub <mgolub@suse.com>
    trociny committed May 12, 2021
    Configuration menu
    Copy the full SHA
    9059c72 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. osd: don't assert in-flight backfill is always in recovery list

    In PrimaryLogPG::on_failed_pull, we unconditionally remove soid
    from recovering list, but remove it from backfills_in_flight only
    when the backfill source is the primary osd.
    
    Fixes: https://tracker.ceph.com/issues/50351
    Signed-off-by: Mykola Golub <mgolub@suse.com>
    (cherry picked from commit 9b78e00)
    trociny committed May 13, 2021
    Configuration menu
    Copy the full SHA
    09ae7bd View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. qa/tasks/ceph_manager: fix assertion

    The osd may be 0.
    
    Signed-off-by: Mykola Golub <mgolub@suse.com>
    (cherry picked from commit 93139db)
    trociny committed May 25, 2021
    Configuration menu
    Copy the full SHA
    87fa9df View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. qa/suites/rados: add backfill_unfound test

    Fixes: https://tracker.ceph.com/issues/50925
    Signed-off-by: Mykola Golub <mgolub@suse.com>
    (cherry picked from commit 0a9f7e1)
    
    Conflicts:
        qa/suites/rados/singleton/all/ec-backfill-unfound.yaml:
            log-whitelist instead of log-ignorelist
    trociny committed May 26, 2021
    Configuration menu
    Copy the full SHA
    e67b3f7 View commit details
    Browse the repository at this point in the history