Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Fix for query params resetting on change-password #41377

Merged
merged 1 commit into from May 18, 2021
Merged

mgr/dashboard: Fix for query params resetting on change-password #41377

merged 1 commit into from May 18, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented May 18, 2021 •
edited

Fixes: https://tracker.ceph.com/issues/50857
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 requested a review from a team May 18, 2021 09:06
@nizamial09 nizamial09 requested a review from a team as a code owner May 18, 2021 09:06
@nizamial09 nizamial09 added this to In progress in Dashboard via automation May 18, 2021
@nizamial09 nizamial09 requested review from callithea, aaSharma14, alfonsomthd, avanthakkar and epuertat and removed request for a team May 18, 2021 09:06
@nizamial09 nizamial09 mentioned this pull request May 18, 2021
Merged
3 tasks
@alfonsomthd alfonsomthd added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label May 18, 2021
Dashboard automation moved this from In progress to Reviewer approved May 18, 2021
epuertat
epuertat approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Super quick fix. Thanks @nizamial09 !

@epuertat epuertat merged commit 8f97023 into ceph:master May 18, 2021
Dashboard automation moved this from Reviewer approved to Done May 18, 2021
@epuertat epuertat deleted the change-password-preserve-url-fix branch May 18, 2021 15:22
@nizamial09 nizamial09 mentioned this pull request May 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@epuertat epuertat epuertat approved these changes

@callithea callithea Awaiting requested review from callithea

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

Assignees
No one assigned
Labels
bug-fix dashboard needs-review pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
3 participants
@nizamial09 @alfonsomthd @epuertat