Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: drop container image name and id from services list #41426

Merged
merged 1 commit into from May 24, 2021
Merged

mgr/dashboard: drop container image name and id from services list #41426

merged 1 commit into from May 24, 2021

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented May 19, 2021 •
edited

Dropping Container image name and id columns from the Services list as orch ls no more contains that info after this change

Fixes: https://tracker.ceph.com/issues/50889
Signed-off-by: Avan Thakkar athakkar@redhat.com

Before:
revert

After:
Screenshot from 2021-05-20 04-00-54

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@avanthakkar avanthakkar requested a review from a team May 19, 2021 21:48
@avanthakkar avanthakkar added this to In progress in Dashboard via automation May 19, 2021
@avanthakkar avanthakkar requested review from pereman2 and Waadkh7 and removed request for a team May 19, 2021 21:48
@avanthakkar avanthakkar force-pushed the drop-container-image-columns branch from 37aa3b8 to 72c4d29 Compare May 19, 2021 21:51
@avanthakkar avanthakkar requested a review from a team as a code owner May 19, 2021 21:51
@avanthakkar
Copy link
Contributor Author

As orch ls o/p no more provides the container image id & name should we hide those columns or just remove it completely from code? I've just hidden for now.

@pereman2
Copy link
Contributor

I'm not a fan of having dead code so I would remove it tbh.

@avanthakkar
Copy link
Contributor Author

avanthakkar commented May 20, 2021 •
edited

I'm not a fan of having dead code so I would remove it tbh.

Yes I agree with you. And anyways even if someone wants to use those columns it will show empty, so I guess better remove it. Thanks @pereman2 !

mgr/dashboard: drop container image name and id from services list
ee98d73 
Fixes: https://tracker.ceph.com/issues/50889
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Dropping container image name and id columns from services list.
@avanthakkar avanthakkar force-pushed the drop-container-image-columns branch from 72c4d29 to ee98d73 Compare May 20, 2021 11:19
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@nizamial09 nizamial09 added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label May 20, 2021
nizamial09
nizamial09 approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avanthakkar You can add the PR or commit link where this got dropped in the description.

Dashboard automation moved this from In progress to Reviewer approved May 20, 2021
@avanthakkar
Copy link
Contributor Author

@avanthakkar You can add the PR or commit link where this got dropped in the description.

Done!

@avanthakkar avanthakkar moved this from Reviewer approved to Ready-to-merge in Dashboard May 24, 2021
epuertat
epuertat approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @avanthakkar ! Let's go with this, as it needs to be fixed asap. But we should go next with this follow-up tracker: https://tracker.ceph.com/issues/50323

Dashboard automation moved this from Ready-to-merge to Reviewer approved May 24, 2021
@epuertat epuertat merged commit 29e31ac into ceph:master May 24, 2021
Dashboard automation moved this from Reviewer approved to Done May 24, 2021
@epuertat epuertat deleted the drop-container-image-columns branch May 24, 2021 18:37
@avanthakkar avanthakkar mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereman2 pereman2 pereman2 approved these changes

@epuertat epuertat epuertat approved these changes

@Waadkh7 Waadkh7 Waadkh7 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

Assignees
No one assigned
Labels
dashboard needs-review pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
5 participants
@avanthakkar @pereman2 @epuertat @Waadkh7 @nizamial09