qa/upgrade: conditionally disable update_features tests #41514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will test them through teuthology |
trociny
reviewed
May 25, 2021
ideepika
force-pushed
the
wip-49592-upgrade
branch
2 times, most recently
from
fc7cf53
to
44267c0
Compare
This was referenced May 27, 2021
Merged
trociny
requested changes
May 28, 2021
src/test/librbd/test_notify.py
Outdated
| print("rebuild object map") | ||
| image.rebuild_object_map() | ||
| assert(not image.is_exclusive_lock_owner()) | ||
| assert((image.flags() & RBD_FLAG_OBJECT_MAP_INVALID) == 0) | ||
|
|
||
| if 'RBD_DISABLE_UPDATE_FEATURES' in os.environ: |
There was a problem hiding this comment.
Actually it should be not in os.environ.
There was a problem hiding this comment.
@trociny you are right, apologies, silly of me, updated.
ideepika
force-pushed
the
wip-49592-upgrade
branch
from
44267c0
to
3ce5703
Compare
with the recent support for async rbd operations from pacific+ when an
older client(non async support) goes on upgrade, and simultaneously
interacts with a newer client which expects the requests to be async,
experiences hang; considering the return code for request completion to
be acknowledgement for async request, which then keeps waiting for
another acknowledgement of request completion.
this if happens should be a rare only when lockowner is an old client
and should be deferred if compatibility issues arises.
see also: 5412304(octopus)
Signed-off-by: Deepika <dupadhya@redhat.com>
ideepika
force-pushed
the
wip-49592-upgrade
branch
from
3ce5703
to
9c0b239
Compare
trociny
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the recent support for async rbd operations from pacific+ when an
older client(non async support) goes on upgrade, and simultaneously
interacts with a newer client which expects the requests to be async,
experiences hang; considering the return code for request completion to
be acknowledgement for async request, which then keeps waiting for
another acknowledgement of request completion.
see also: 5412304(octopus)
Signed-off-by: Deepika dupadhya@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox