doc/rbd: document cp versus deep cp #41529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idryomov
reviewed
May 25, 2021
idryomov
reviewed
May 25, 2021
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Yenya
force-pushed
the
rbd-deep-cp-docs
branch
2 times, most recently
from
c495166
to
f2e4fe8
Compare
idryomov
reviewed
May 27, 2021
idryomov
approved these changes
May 27, 2021
idryomov
changed the title
|
Sorry, one more thing -- please update the commit title to match the title of the PR (I have tweaked it). |
I found that the difference between "rbd cp" and "rbd deep cp", i.e. what "deep" means in this context, is documented only in the mailing list archive and in the Mimic reelase notes. Let's make the difference explicit in the manpage and in rbd --help. Signed-off-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the difference between "rbd cp" and "rbd deep cp",
i.e. what "deep" means in this context, is documented only in
the mailing list archive and in the Mimic reelase notes.
Let's make the difference explicit in the manpage and in rbd --help.
Signed-off-by: Jan "Yenya" Kasprzak kas@fi.muni.cz
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox