mgr: expose CRUSHMap.find_roots() #41552
Conversation
so mgr module could use it to enumerate all nodes without parents See-also: https://tracker.ceph.com/issues/50971 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-mgr-find-roots
branch
from
fb5e2dc
to
7858b56
Compare
There was a problem hiding this comment.
LGTM! Thanks @tchaikov . Btw just a question though (not related to PR), I see some difference in o/p of ceph osd tree and crush buckets list, for e.g.
"id": -1,
"name": "default",
"type_id": 11,
"type_name": "root",
}
]
},
{
"id": -2,
"name": "default~hdd",
"type_id": 11,
"type_name": "root",
this is the crush bucket list, but for crush tree I don't see the name=default~hdd. So are these not considered under crush tree?
|
not sure what do you mean by "bucket tree", but FWIW, the notation of "default~hdd" is the result of how we compose buckets with class (like "hdd" and "ssd"). |
No, "crush tree". Ok, yes but I mean to ask that I can't see these buckets (with class hdd, ssd, etc..) in the output of |
mgr: expose CRUSHMap.find_roots() Reviewed-by: Avan Thakkar <athakkar@redhat.com>
so mgr module could use it to enumerate all nodes without parents
See-also: https://tracker.ceph.com/issues/50971
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox