Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd/ECBackend: Fix null pointer dereference when enabling jaeger tracing #41604

Merged
merged 1 commit into from Jun 5, 2021
Merged

osd/ECBackend: Fix null pointer dereference when enabling jaeger tracing #41604

merged 1 commit into from Jun 5, 2021

Conversation

t-msn
Copy link
Contributor

@t-msn t-msn commented Jun 1, 2021

As comment in header says client_op might be null, we need to check it
first before accessing client_op->osd_parent_span.

Fixes: #51030
Signed-off-by: Misono Tomohiro misono.tomohiro@jp.fujitsu.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@t-msn
osd/ECBackend: Fix null pointer dereference when enabling jaeger tracing
32964b3 
As comment in header says client_op might be null, we need to check it
first before accessing client_op->osd_parent_span.

Fixes: ceph#51030
Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
@github-actions github-actions bot added the core label Jun 1, 2021
@neha-ojha neha-ojha requested a review from ideepika June 4, 2021 23:00
ideepika
ideepika approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@ideepika ideepika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @t-msn!

@tchaikov
Copy link
Contributor

tchaikov commented Jun 5, 2021

@tchaikov tchaikov merged commit 4857c35 into ceph:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ideepika ideepika ideepika approved these changes

Assignees
No one assigned
Labels
core wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@t-msn @tchaikov @ideepika