Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Cluster Creation Add Host Section #41720

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Jun 6, 2021

Add host section of the cluster creation workflow.
Screenshot from 2021-07-05 16-54-44
Screenshot from 2021-07-05 16-55-01

Routed Modal
host-add

TODO : Implement unit tests for cluster-creation add host section and the wizard component.

Fixes: https://tracker.ceph.com/issues/50565
Fixes: https://tracker.ceph.com/issues/51517

Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 added this to In progress in Dashboard via automation Jun 6, 2021
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@nizamial09 nizamial09 marked this pull request as ready for review July 5, 2021 11:53
@nizamial09 nizamial09 requested a review from a team as a code owner July 5, 2021 11:53
@nizamial09 nizamial09 requested review from pereman2, aaryanporwal and cypherean and removed request for a team July 5, 2021 11:53
Dashboard automation moved this from In progress to Review in progress Jul 5, 2021
@nizamial09 nizamial09 added feature and removed tests labels Jul 5, 2021
@nizamial09 nizamial09 force-pushed the create-cluster-add-hosts branch 2 times, most recently from 2a75363 to 895e441 Compare July 6, 2021 06:36
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nizamial09 !

Add host section of the cluster creation workflow.

Fixes: https://tracker.ceph.com/issues/50565
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

jenkins test dashboard

Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Dashboard automation moved this from Review in progress to Reviewer approved Jul 7, 2021
@alfonsomthd alfonsomthd merged commit 5f8e0ba into ceph:feature-50336-cluster-creation-wizard Jul 7, 2021
Dashboard automation moved this from Reviewer approved to Done Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
4 participants