-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Cluster Creation Add Host Section #41720
mgr/dashboard: Cluster Creation Add Host Section #41720
Conversation
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
b349c42
to
c9a8635
Compare
c9a8635
to
95eabe8
Compare
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
95eabe8
to
c1d5a5b
Compare
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
7dbbc9b
to
05dae35
Compare
c1d5a5b
to
3d2b1b0
Compare
3d2b1b0
to
2e0e5f4
Compare
27d3b19
to
825289e
Compare
src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts
Outdated
Show resolved
Hide resolved
...ind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.html
Show resolved
Hide resolved
...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.ts
Show resolved
Hide resolved
...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/shared/services/wizard-steps.service.ts
Outdated
Show resolved
Hide resolved
825289e
to
86cf459
Compare
2a75363
to
895e441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @nizamial09 !
Add host section of the cluster creation workflow. Fixes: https://tracker.ceph.com/issues/50565 Signed-off-by: Nizamudeen A <nia@redhat.com>
895e441
to
03075c5
Compare
jenkins test dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add host section of the cluster creation workflow.
![Screenshot from 2021-07-05 16-54-44](https://user-images.githubusercontent.com/71764184/124467484-85e30980-ddb5-11eb-9da4-45d0352059d8.png)
![Screenshot from 2021-07-05 16-55-01](https://user-images.githubusercontent.com/71764184/124467493-87143680-ddb5-11eb-8554-1a7e7743033c.png)
Routed Modal
![host-add](https://user-images.githubusercontent.com/71764184/124469983-a5c7fc80-ddb8-11eb-8067-f8b40f00d288.png)
TODO : Implement unit tests for cluster-creation add host section and the wizard component.Fixes: https://tracker.ceph.com/issues/50565
Fixes: https://tracker.ceph.com/issues/51517
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox