Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephadm: expose gather-facts api method #41816

Merged
merged 1 commit into from Jun 23, 2021
Merged

cephadm: expose gather-facts api method #41816

merged 1 commit into from Jun 23, 2021

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Jun 11, 2021 •
edited

This PR intends to expose host metadata(gather-facts) api method

Fixes: https://tracker.ceph.com/issues/51209

Signed-off-by: Avan Thakkar athakkar@redhat.com
Signed-off-by: Aashish Sharma aasharma@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@avanthakkar avanthakkar changed the title Signed-off-by: Avan Thakkar <athakkar@redhat.com> Add host_facts to the inventory list. Jun 11, 2021
@avanthakkar avanthakkar added this to In progress in Dashboard via automation Jun 14, 2021
sebastian-philipp
sebastian-philipp reviewed Jun 14, 2021
View reviewed changes
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/orchestrator/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/orchestrator/module.py Outdated Show resolved Hide resolved
sebastian-philipp
sebastian-philipp suggested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@sebastian-philipp sebastian-philipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request changes

Dashboard automation moved this from In progress to Review in progress Jun 14, 2021
@aaSharma14 aaSharma14 force-pushed the add-gather-facts-to-inventory branch from b769f47 to 821eaa6 Compare June 15, 2021 11:00
@aaSharma14 aaSharma14 force-pushed the add-gather-facts-to-inventory branch from 821eaa6 to 05afb6d Compare June 15, 2021 11:07
@avanthakkar avanthakkar marked this pull request as ready for review June 15, 2021 11:07
@avanthakkar avanthakkar requested review from a team as code owners June 15, 2021 11:07
@avanthakkar avanthakkar requested review from nizamial09, epuertat and alfonsomthd and removed request for a team and aaSharma14 June 15, 2021 11:07
@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from 05afb6d to 1184b50 Compare June 15, 2021 13:07
@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from 1184b50 to e92a01a Compare June 16, 2021 10:04
@avanthakkar avanthakkar changed the title Add host_facts to the inventory list. cephadm: expose gather-facts api method Jun 16, 2021
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from 0f8485f to d2a3703 Compare June 17, 2021 11:06
epuertat
epuertat previously requested changes Jun 18, 2021
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see some unit testing.

src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
src/pybind/mgr/dashboard/services/orchestrator.py Outdated Show resolved Hide resolved
Dashboard automation moved this from Reviewer approved to Review in progress Jun 18, 2021
@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch 4 times, most recently from 78be92c to 615e16c Compare June 18, 2021 13:10
@avanthakkar
Copy link
Contributor Author

jenkins test make check

@avanthakkar avanthakkar changed the base branch from master to feature-50336-cluster-creation-wizard June 21, 2021 08:37
@avanthakkar avanthakkar requested a review from a team June 21, 2021 08:37
@avanthakkar avanthakkar requested a review from a team as a code owner June 21, 2021 08:37
@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from 615e16c to 7a57edd Compare June 21, 2021 10:55
@avanthakkar
Copy link
Contributor Author

I'd love to see some unit testing.

Added a unit-test!

@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from 7a57edd to 15d3454 Compare June 22, 2021 08:39
@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from 15d3454 to b8ea2e3 Compare June 22, 2021 08:58
cephadm: expose gather-facts api method
f103702 
Fixes: https://tracker.ceph.com/issues/51209

This PR intends to expose host metadata(gather-facts) api method

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@avanthakkar avanthakkar force-pushed the add-gather-facts-to-inventory branch from b8ea2e3 to f103702 Compare June 22, 2021 11:13
@sebastian-philipp sebastian-philipp removed the wip-swagner-testing My Teuthology tests label Jun 22, 2021
@avanthakkar avanthakkar dismissed epuertat’s stale review June 23, 2021 08:48

sugesstions addressed.

Dashboard automation moved this from Review in progress to Reviewer approved Jun 23, 2021
@avanthakkar avanthakkar moved this from Reviewer approved to Ready-to-merge in Dashboard Jun 23, 2021
epuertat
epuertat approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/pybind/mgr/cephadm/tests/test_facts.py
@pytest.fixture()
def test_facts():
facts = {'node-1.ceph.com', {'bios_version': 'F2', 'cpu_cores': 16}}
HostCache.facts = facts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Dashboard automation moved this from Ready-to-merge to Reviewer approved Jun 23, 2021
@epuertat epuertat merged commit a40bcb0 into ceph:feature-50336-cluster-creation-wizard Jun 23, 2021
Dashboard automation moved this from Reviewer approved to Done Jun 23, 2021
@epuertat epuertat deleted the add-gather-facts-to-inventory branch June 23, 2021 11:09
@avanthakkar avanthakkar mentioned this pull request Aug 30, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaSharma14 aaSharma14 aaSharma14 left review comments

@nizamial09 nizamial09 nizamial09 approved these changes

@sebastian-philipp sebastian-philipp sebastian-philipp approved these changes

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@epuertat epuertat epuertat approved these changes

@jmolmo jmolmo Awaiting requested review from jmolmo

@pereman2 pereman2 Awaiting requested review from pereman2

Assignees
No one assigned
Labels
cephadm dashboard needs-review orchestrator pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
7 participants
@avanthakkar @sebastian-philipp @alfonsomthd @pereman2 @epuertat @aaSharma14 @nizamial09