pacific: Backport of bucket notifications tests #41850

TRYTOBE8TME · 2021-06-15T05:15:56Z

Checklist

References tracker ticket
Updates documentation if necessary
Includes tests for new functionality or reproducer for bug

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

yuvalif · 2021-06-16T14:28:34Z

can you please paste a link to passing teuthology run?

yuvalif · 2021-06-16T14:30:53Z

in the commits where you had conflicts, please remove the following text fro the commit comment (keep all the rest of your comments):

It looks like you may be committing a cherry-pick.
 If this is not correct, please run
	git update-ref -d CHERRY_PICK_HEAD
 and try again.

yuvalif · 2021-06-16T14:31:42Z

qa/suites/rgw/notifications/tasks/test_amqp.yaml

+- notification-tests:
+    client.0:
+      force-branch: wip-backport-to-pacific
+      git_remote: https://github.com/TRYTOBE8TME/


don't forget to fix that before merge

Yup, I'll take care.

yuvalif · 2021-06-16T14:31:52Z

qa/suites/rgw/notifications/tasks/test_kafka.yaml

+- notification-tests:
+    client.0:
+      force-branch: wip-backport-to-pacific
+      git_remote: https://github.com/TRYTOBE8TME/


don't forget to fix that before merge

yuvalif · 2021-06-16T14:32:00Z

qa/suites/rgw/notifications/tasks/test_others.yaml

+- notification-tests:
+    client.0:
+      force-branch: wip-backport-to-pacific
+      git_remote: https://github.com/TRYTOBE8TME/


don't forget to fix that before merge

TRYTOBE8TME · 2021-06-16T16:22:16Z

can you please paste a link to passing teuthology run?

Teuthology link: https://pulpito.ceph.com/kapandya-2021-06-14_15:42:05-rgw:notifications-wip-bntests-backport-distro-basic-smithi/

github-actions · 2021-07-15T15:26:01Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

cbodley · 2021-08-17T19:23:45Z

please rebase

github-actions · 2021-09-21T19:14:16Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

yuriw · 2021-10-01T15:52:25Z

@TRYTOBE8TME pls rebase and add needs-qa, thx

cbodley

failed qa

yuriw · 2022-08-04T14:30:12Z

@TRYTOBE8TME pls add needs-qa tag when it's ready for testing

yuvalif · 2022-08-28T16:33:47Z

src/test/rgw/bucket_notification/test_bn.py

+
+
+@attr('amqp_test')
+def test_ps_s3_multipart_on_master():


please change according to: https://github.com/ceph/ceph/blob/main/src/test/rgw/bucket_notification/test_bn.py#L2069

the multipart fix was backported. see: 64bb327

yuvalif · 2022-08-28T16:37:24Z

src/test/rgw/bucket_notification/test_bn.py

+
+
+@attr('amqp_test')
+def test_ps_s3_metadata_on_master():


there is a test issue that was fixed in: https://github.com/ceph/ceph/blob/main/src/test/rgw/bucket_notification/test_bn.py#L2158

the check in lines 1751 was replaced with:
https://github.com/ceph/ceph/blob/main/src/test/rgw/bucket_notification/test_bn.py#L2239

yuvalif · 2022-08-28T16:39:28Z

src/test/rgw/bucket_notification/test_bn.py

+
+
+@attr('amqp_test')
+def test_ps_s3_versioned_deletion_on_master():


test issue that was fixed in:
https://github.com/ceph/ceph/blob/main/src/test/rgw/bucket_notification/test_bn.py#L2445

updated

TRYTOBE8TME · 2022-09-22T09:27:09Z

Passing teuthology: https://pulpito.ceph.com/kapandya-2022-09-22_06:30:56-rgw:notifications-wip-backport-to-pacific-distro-default-smithi/

P.S: the error seen here was already resolved as a part of another PR which is pending backport.

dang · 2022-09-27T16:06:53Z

@cbodley Can we merge this?

cbodley · 2022-09-27T16:09:43Z

@TRYTOBE8TME it looks like there are unresolved comments about git_remote: https://github.com/TRYTOBE8TME/

also move the amqp ssl tests to 'test_bn.py' this fix combines commit: 1418bcc with commit: 979335f Fixes: https://tracker.ceph.com/issues/49800 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com> (cherry picked from commit 0fcb337) Conflicts: src/test/rgw/bucket_notification/test_bn.py To resolve the conflicts I removed skip_amqp from the beginning of amqp tests and there was a addition of amqp_ssl_test in the list. I've added 'etags' to verify_s3_records_by_elements function and also added etags parameter in some places in test_ps_s3_notification_push_kafka_on_master.

TRYTOBE8TME · 2022-10-10T08:01:11Z

jenkins test make check

TRYTOBE8TME · 2022-10-11T15:48:48Z

@TRYTOBE8TME it looks like there are unresolved comments about git_remote: https://github.com/TRYTOBE8TME/

resolved! Thanks for pointing @cbodley

TRYTOBE8TME · 2022-10-11T15:49:25Z

jenkins test make check

github-actions · 2023-05-23T16:05:29Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

yuvalif · 2023-09-12T09:47:03Z

@cbodley do we still need to backport tests to pacific?

cbodley · 2023-09-13T18:51:11Z

@cbodley do we still need to backport tests to pacific?

@yuvalif we'll likely do one or two more point releases for pacific. but these bucket notification tests may not be worth the effort

yuvalif · 2023-09-14T09:08:46Z

closing, according to the comment above

TRYTOBE8TME requested a review from yuvalif June 15, 2021 05:16

github-actions bot added documentation rgw tests labels Jun 15, 2021

github-actions bot added this to the pacific milestone Jun 15, 2021

yuvalif reviewed Jun 16, 2021

View reviewed changes

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from 25acd7e to 16ef5fb Compare June 16, 2021 16:27

yuvalif self-requested a review June 17, 2021 11:50

yuvalif approved these changes Jun 17, 2021

View reviewed changes

github-actions bot added the needs-rebase label Jul 15, 2021

yuriw added wip-yuri4-testing and removed wip-yuri4-testing labels Aug 9, 2021

yuriw added wip-yuri4-testing and removed wip-yuri4-testing labels Aug 17, 2021

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from 16ef5fb to 77a0cc6 Compare August 18, 2021 05:12

github-actions bot removed the needs-rebase label Aug 18, 2021

yuvalif added the needs-qa label Sep 20, 2021

github-actions bot added the needs-rebase label Sep 21, 2021

yuriw added wip-yuri2-testing and removed needs-qa wip-yuri2-testing labels Oct 1, 2021

cbodley previously requested changes Aug 4, 2022

View reviewed changes

yuriw removed the wip-yuri3-testing label Aug 4, 2022

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from 1ad0e95 to 76dcaff Compare August 16, 2022 07:19

yuvalif reviewed Aug 28, 2022

View reviewed changes

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from 76dcaff to af2f710 Compare August 29, 2022 09:42

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch 4 times, most recently from 02c446b to 14c8f01 Compare September 6, 2022 15:04

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from 14c8f01 to 777352f Compare September 12, 2022 09:35

anthonyeleven approved these changes Sep 15, 2022

View reviewed changes

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from 777352f to c706a63 Compare September 19, 2022 09:23

TRYTOBE8TME force-pushed the wip-backport-to-pacific branch from c706a63 to 1bb5d4d Compare October 10, 2022 07:03

github-actions bot added the needs-rebase label May 23, 2023

yuvalif closed this Sep 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pacific: Backport of bucket notifications tests #41850

pacific: Backport of bucket notifications tests #41850

TRYTOBE8TME commented Jun 15, 2021

yuvalif commented Jun 16, 2021

yuvalif commented Jun 16, 2021

yuvalif Jun 16, 2021

TRYTOBE8TME Jun 16, 2021

yuvalif Jun 16, 2021

yuvalif Jun 16, 2021

TRYTOBE8TME commented Jun 16, 2021

github-actions bot commented Jul 15, 2021

cbodley commented Aug 17, 2021

github-actions bot commented Sep 21, 2021

yuriw commented Oct 1, 2021

cbodley left a comment

yuriw commented Aug 4, 2022

yuvalif Aug 28, 2022

yuvalif Aug 28, 2022

yuvalif Aug 28, 2022

TRYTOBE8TME commented Sep 22, 2022

dang commented Sep 27, 2022

cbodley commented Sep 27, 2022

TRYTOBE8TME commented Oct 10, 2022

TRYTOBE8TME commented Oct 11, 2022

TRYTOBE8TME commented Oct 11, 2022

github-actions bot commented May 23, 2023

yuvalif commented Sep 12, 2023

cbodley commented Sep 13, 2023

yuvalif commented Sep 14, 2023



		@attr('amqp_test')
		def test_ps_s3_versioned_deletion_on_master():

pacific: Backport of bucket notifications tests #41850

pacific: Backport of bucket notifications tests #41850

Conversation

TRYTOBE8TME commented Jun 15, 2021

Checklist

yuvalif commented Jun 16, 2021

yuvalif commented Jun 16, 2021

yuvalif Jun 16, 2021

Choose a reason for hiding this comment

TRYTOBE8TME Jun 16, 2021

Choose a reason for hiding this comment

yuvalif Jun 16, 2021

Choose a reason for hiding this comment

yuvalif Jun 16, 2021

Choose a reason for hiding this comment

TRYTOBE8TME commented Jun 16, 2021

github-actions bot commented Jul 15, 2021

cbodley commented Aug 17, 2021

github-actions bot commented Sep 21, 2021

yuriw commented Oct 1, 2021

cbodley left a comment

Choose a reason for hiding this comment

yuriw commented Aug 4, 2022

yuvalif Aug 28, 2022

Choose a reason for hiding this comment

yuvalif Aug 28, 2022

Choose a reason for hiding this comment

yuvalif Aug 28, 2022

Choose a reason for hiding this comment

TRYTOBE8TME commented Sep 22, 2022

dang commented Sep 27, 2022

cbodley commented Sep 27, 2022

TRYTOBE8TME commented Oct 10, 2022

TRYTOBE8TME commented Oct 11, 2022

TRYTOBE8TME commented Oct 11, 2022

github-actions bot commented May 23, 2023

yuvalif commented Sep 12, 2023

cbodley commented Sep 13, 2023

yuvalif commented Sep 14, 2023