Add more CLI options to ceph-rest-api #4191
Conversation
In order to containerized ceph-rest-api we need to expose some options on the CLI directly. We don't want to rely on reading the ceph.conf. In this commit, we expose all the configuration options as CLI extra parameters. Now you can run the API like this: ceph-rest-api --addr 192.168.0.24:5001 --log-file /dev/null --base-url /api/1.0/ --log-level debug Signed-off-by: Sébastien Han <sebastien.han@enovance.com>
|
SUCCESS: the output of run-make-check.sh on centos-7 for d1eb802 is http://paste2.org/hAanwUCd |
Sent from 
tchaikov
changed the title
ghost
self-assigned this
|
looks good: could you add some tests ? |
|
I don't think there are any tests for this. Merci ! |
ghost
removed their assignment
|
I'm not the right person to review this patch. If it was me I would write tests modelled after https://github.com/ceph/ceph/blob/hammer/src/test/osd/osd-scrub-repair.sh (i.e. create a mini cluster and run a few commands, checking the expected side effects) or write unittests which I can't find for this command or the corresponding python module. I suspect testing is done somewhere else and it would be best if someone actually using the ceph-rest-api could comment. |
|
@leseb feel free to re-open as soon as you have time to write the tests (I realize that requires significant work and researching the good person to talk to etc. ;-) |
ghost
closed this
|
@dachary well, do I really need to write ALL the tests simply because I added a few options? :) |
|
@leseb of course not ! Just the test related to your options ;-) |
|
@dachary ok I'll do that, thanks. |
In order to containerized ceph-rest-api we need to expose some options
on the CLI directly. We don't want to rely on reading the ceph.conf. In
this commit, we expose all the configuration options as CLI extra
parameters.
Now you can run the API like this:
ceph-rest-api --addr 192.168.0.24:5001 --log-file /dev/null --base-url
/api/1.0/ --log-level debug
Signed-off-by: Sébastien Han sebastien.han@enovance.com