Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs-mirror: reopen logs on SIGHUP #41988

Merged
merged 2 commits into from Jun 28, 2021
Merged

cephfs-mirror: reopen logs on SIGHUP #41988

merged 2 commits into from Jun 28, 2021

Conversation

vshankar
Copy link
Contributor

Fixes: http://tracker.ceph.com/issues/51318
Signed-off-by: Venky Shankar vshankar@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@vshankar vshankar added the cephfs Ceph File System label Jun 23, 2021
@vshankar vshankar requested a review from a team June 23, 2021 12:20
@vshankar
cephfs-mirror: reopen logs on SIGHUP
68ad416 
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar
logrotate: include cephfs-mirror daemon
957bae2 
Fixes: http://tracker.ceph.com/issues/51318
Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar
Copy link
Contributor Author

added cephfs-mirror to logrotate conf.

@vshankar
Copy link
Contributor Author

jenkins test make check

1 similar comment
@vshankar
Copy link
Contributor Author

jenkins test make check

mchangir
mchangir reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be too much to add a line in the commit message saying ...
eventually the global ceph context object invokes the method named reopen_logs() of the low level RADOS object ?

@vshankar
Copy link
Contributor Author

Would it be too much to add a line in the commit message saying ...
eventually the global ceph context object invokes the method named reopen_logs() of the low level RADOS object ?

Maybe, but its pretty obvious (to me atleast) that there is a ceph context helper that does the job.

@batrick
Copy link
Member

batrick commented Jun 28, 2021

https://tracker.ceph.com/projects/cephfs/wiki/Master#2021-June-26

@batrick batrick merged commit eca490c into ceph:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchangir mchangir mchangir left review comments

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System needs-qa wip-pdonnell-testing
Projects
None yet
Milestone
No milestone
3 participants
@vshankar @batrick @mchangir