Fix some memory leaks in Ceph #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error from cppcheck: [src/common/fiemap.cc:73]: (error) Common realloc mistake: 'fiemap' nulled but not freed upon failure Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix error from cppcheck: [src/os/FileStore.cc:512]: (error) Common realloc mistake: 'fiemap' nulled but not freed upon failure Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix error from cppcheck: [src/rgw/rgw_xml.cc:212]: (error) Common realloc mistake: 'buf' nulled but not freed upon failure Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix some memory leaks in packet-ceph.c. Error from cppcheck was: [wireshark/ceph/packet-ceph.c:215]: (error) Memory leak: plop [wireshark/ceph/packet-ceph.c:237]: (error) Memory leak: plop [wireshark/ceph/packet-ceph.c:543]: (error) Memory leak: fsid_dec Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix some memory leaks in case of error handling due to failed client->open() calls. Error from cppcheck was: [src/client/SyntheticClient.cc:1980]: (error) Memory leak: buf [src/client/SyntheticClient.cc:2040]: (error) Memory leak: buf [src/client/SyntheticClient.cc:2090]: (error) Memory leak: buf
Fix 4K memory leak in case RGWClientIO::read() fails in read_all_chunked_input(). Error from cppcheck was: Checking src/rgw/rgw_rest.cc... [src/rgw/rgw_rest.cc:688]: (error) Memory leak: data Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Closed
gregsfortytwo
referenced
this pull request
Sep 20, 2013
This way users can't put snapshots on their clusters unless they explicitly ask for the and have seen a warning message. We take a bit of the MDSMap flags in order to do so. The only thing a little weird here is that anybody who upgrades to this patch who already has snapshots will hit the EPERM and have to go through the warning, but it doesn't impact existing snapshots at all so they should be good. Fixes: #6332 Signed-off-by: Greg Farnum <greg@inktank.com>
gregsfortytwo
referenced
this pull request
in somnathr/ceph
Jun 3, 2014
IndexManager now has a Index caching. Index will only be created if not found in the cache. Earlier, each op is creating an Index object and other ops requesting the same index needed to wait till previous op is done. Also, after finishing lookup, this Index object was destroyed. Now, a RWlock is been introduced in the CollectionIndex class and that is responsible for sync between lookup and create. Also, since these Index objects are persistent there is no need to use smart pointers. So, Index is a CollecIndex* now. Signed-off-by: Somnath Roy <somnath.roy@sandisk.com>
Merged
XinzeChi
pushed a commit
to XinzeChi/ceph
that referenced
this pull request
Jan 29, 2016
ceph.spec.in: We no longer need redhat-lsb-core
TaewoongKim
added a commit
to TaewoongKim/ceph
that referenced
this pull request
Oct 27, 2017
f356c45 Add missing anticipation_timeout argument for PullPriorityQueue constructor 9896448 Merge pull request ceph#42 from tchaikov/wip-cmake 979899e add travis CI on gnu/linux 8a3dabd cmake: the built archives are located in ${binary_dir} ee15ced cmake: check for include in /usr/include also git-subtree-dir: src/dmclock git-subtree-split: f356c45461ce959ec0469c03bcffbe458bacfddb
adamemerson
added a commit
to adamemerson/ceph
that referenced
this pull request
Nov 4, 2017
d1ff03b667 Merge pull request ceph#44 from adamemerson/wip-system-includes 4cc4b949ca build: Mark dependency includes as SYSTEM in dmclock 05096c1756 Merge pull request ceph#43 from TaewoongKim/anticipation_conf f356c45461 Add missing anticipation_timeout argument for PullPriorityQueue constructor 9896448ec5 Merge pull request ceph#42 from tchaikov/wip-cmake 979899ef86 add travis CI on gnu/linux 8a3dabdbee cmake: the built archives are located in ${binary_dir} ee15ced3e9 cmake: check for include in /usr/include also git-subtree-dir: src/dmclock git-subtree-split: d1ff03b667d9551478b2803ea533fc356ca441a9
tspmelo
pushed a commit
to tspmelo/ceph
that referenced
this pull request
Jan 29, 2018
…2-nodb-pylint `models` folder: make pylint happy
3 tasks
galsalomon66
referenced
this pull request
in galsalomon66/ceph
Sep 17, 2022
galsalomon66
referenced
this pull request
in galsalomon66/ceph
Sep 17, 2022
* fixing text to float convertion (ronen-fr #42) Signed-off-by: gal salomon <gal.salomon@gmail.com> * fix integer conversion; add compile-warning flag Signed-off-by: gal salomon <gal.salomon@gmail.com>
galsalomon66
referenced
this pull request
in galsalomon66/ceph
Sep 17, 2022
* adding object to handle awscli response,first phase. adding warning flags; Signed-off-by: gal salomon <gal.salomon@gmail.com> * fixing text to float conversion (ronen-fr #42) (#64) Signed-off-by: gal salomon <gal.salomon@gmail.com> * fix integer conversion; add compile-warning flag Signed-off-by: gal salomon <gal.salomon@gmail.com> * fix stdin mode; fix compile warnings Signed-off-by: gal salomon <gal.salomon@gmail.com>
jecluis
added a commit
to jecluis/ceph
that referenced
this pull request
Sep 19, 2022
rgw/sfs: bump changelog version
tobias-urdin
pushed a commit
to tobias-urdin/ceph
that referenced
this pull request
Aug 2, 2023
Copy tests for replacing and retaining metadata Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here some patches to fix memory leaks in Ceph found by cppcheck. Patches already send to the ceph-ML (contains fixed version of patch 5/6).
Please pull from wip-da-sca-memleaks.