-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/librbd: use really invalid domain #42005
Conversation
Hm, it is now fails on Jenkins with:
Although it passess for me locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the one usually used is "foo.invalid", but "dne.invalid" of course works too.
I remember seeing |
This is probably because on the jenkins node the response is |
@trociny Let's switch to "foo.example", it appears to do the trick. |
in TestMockMigrationHttpClient.OpenResolveFail Fixes: https://tracker.ceph.com/issues/51342 Signed-off-by: Mykola Golub <mgolub@suse.com>
Changed to "foo.example". It seems to work on Jenkins indeed. |
in TestMockMigrationHttpClient.OpenResolveFail
"dne.invalid" seems to be a good choice as according to rfc2606:
".invalid" is intended for use in online construction of domain
names that are sure to be invalid and which it is obvious at a
glance are invalid.
[1] https://datatracker.ietf.org/doc/html/rfc2606#section-2
Fixes: https://tracker.ceph.com/issues/51342
Signed-off-by: Mykola Golub mgolub@suse.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox