Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/librbd: use really invalid domain #42005

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Jun 24, 2021

in TestMockMigrationHttpClient.OpenResolveFail

"dne.invalid" seems to be a good choice as according to rfc2606:

".invalid" is intended for use in online construction of domain
names that are sure to be invalid and which it is obvious at a
glance are invalid.

[1] https://datatracker.ietf.org/doc/html/rfc2606#section-2

Fixes: https://tracker.ceph.com/issues/51342

Signed-off-by: Mykola Golub mgolub@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@trociny
Copy link
Contributor Author

trociny commented Jun 24, 2021

Hm, it is now fails on Jenkins with:

[ RUN      ] TestMockMigrationHttpClient.OpenResolveFail
../src/test/librbd/migration/test_mock_HttpClient.cc:348: Failure
Expected equality of these values:
  -2
  ctx.wait()
    Which is: -11
[  FAILED  ] TestMockMigrationHttpClient.OpenResolveFail (36 ms)

Although it passess for me locally.

Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the one usually used is "foo.invalid", but "dne.invalid" of course works too.

@idryomov
Copy link
Contributor

Hm, it is now fails on Jenkins with:

[ RUN      ] TestMockMigrationHttpClient.OpenResolveFail
../src/test/librbd/migration/test_mock_HttpClient.cc:348: Failure
Expected equality of these values:
  -2
  ctx.wait()
    Which is: -11
[  FAILED  ] TestMockMigrationHttpClient.OpenResolveFail (36 ms)

Although it passess for me locally.

I remember seeing /etc/hosts affecting such tests in the past...

@idryomov
Copy link
Contributor

This is probably because on the jenkins node the response is SERVFAIL instead of NXDOMAIN. We might need to use a well-known domain with a garbage subdomain to ensure the expected NXDOMAIN response.

@tchaikov
Copy link
Contributor

thank you @idryomov and @trociny for the quick fix and review! can we get this fix merged once the "make check" test passes?

@idryomov
Copy link
Contributor

@trociny Let's switch to "foo.example", it appears to do the trick.

in TestMockMigrationHttpClient.OpenResolveFail

Fixes: https://tracker.ceph.com/issues/51342

Signed-off-by: Mykola Golub <mgolub@suse.com>
@trociny
Copy link
Contributor Author

trociny commented Jun 24, 2021

Changed to "foo.example". It seems to work on Jenkins indeed.

@idryomov idryomov merged commit 7641537 into ceph:master Jun 24, 2021
@trociny trociny deleted the wip-51342 branch June 24, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants