Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octopus: mgr/dashboard: fix for right sidebar nav icon not clickable #42015

Merged
merged 1 commit into from Jul 2, 2021

Conversation

avanthakkar
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/51179


backport of #41550
parent tracker: https://tracker.ceph.com/issues/50588

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

fixed the responsive sidebar not opening on click event, and close sidebar on clicking tasks and notification list item because it'll be over shadowed by the sidebar
Signed-off-by: Aaryan Porwal <aaryanporwal2233@gmail.com>
(cherry picked from commit 4e53a13)

 Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
      - Adopt the master branch changes.
@avanthakkar avanthakkar requested a review from a team as a code owner June 24, 2021 17:47
@avanthakkar avanthakkar requested review from pereman2 and Waadkh7 and removed request for a team June 24, 2021 17:47
@avanthakkar avanthakkar added this to the octopus milestone Jun 24, 2021
@avanthakkar avanthakkar added this to In progress in Dashboard via automation Jun 24, 2021
Dashboard automation moved this from In progress to Reviewer approved Jun 25, 2021
@avanthakkar avanthakkar moved this from Reviewer approved to Ready-to-merge in Dashboard Jun 28, 2021
@epuertat epuertat changed the title octopus: mgr/dashboard: fix for right sidebar nav icon not clickable octopus: mgr/dashboard: fix for right sidebar nav icon not clickable Jun 30, 2021
@epuertat
Copy link
Member

jenkins test dashboard

@epuertat epuertat merged commit b4167a4 into ceph:octopus Jul 2, 2021
Dashboard automation moved this from Ready-to-merge to Done Jul 2, 2021
@epuertat epuertat deleted the wip-51179-octopus branch July 2, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
5 participants