libcephsqlite: shutdown RADOS in destructor #42035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 25, 2021
* refs/pull/42035/head: libcephsqlite: shutdown RADOS in destructor
|
Ya... not yet sure why. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 26, 2021
* refs/pull/42035/head: libcephsqlite: register atexit handler for cleanup libcephsqlite: shutdown RADOS in destructor
batrick
force-pushed
the
i51372
branch
3 times, most recently
from
438d20a
to
9b69642
Compare
Fixes: https://tracker.ceph.com/issues/50503 Fixes: https://tracker.ceph.com/issues/51372 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
We need to tear down the ceph vfs when sqlite3 (or other binaries) call exit(). Otherwise global state gets destructed which can cause library threads to segfault or raise exceptions. Also pull vfs struct out of appdata. We need to be able to detect double calls to the atexit handler which, sadly, can happen. Fixes: https://tracker.ceph.com/issues/50503 Fixes: https://tracker.ceph.com/issues/51372 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
Pretty sure this will be fixed by the latest commits. Couldn't reproduce the crash anymore testing locally for 8 hours. QA results should be in soon but sepia appears down. |
neha-ojha
approved these changes
Jun 29, 2021
tchaikov
reviewed
Jun 29, 2021
tchaikov
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/50503
Fixes: https://tracker.ceph.com/issues/51372
Signed-off-by: Patrick Donnelly pdonnell@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox