src/ceph-crash.in: various enhancements and fixes #42055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdout was never used so let's remove it. Signed-off-by: Sébastien Han <seb@redhat.com>
tchaikov
approved these changes
Jul 1, 2021
dmick
reviewed
Jul 2, 2021
dmick
approved these changes
Jul 2, 2021
| @@ -51,7 +51,7 @@ def post_crash(path): | |||
| stderr = pr.communicate(input=f.read()) | |||
| rc = pr.wait() | |||
| f.close() | |||
| if rc != 0: | |||
| if rc != 0 or stderr != "": | |||
There was a problem hiding this comment.
just printing to stderr isn't an error, of course, so I don't know that calling this "failed" is really right, but it's a nit
There was a problem hiding this comment.
Agreed, but as explained in 8a89e01, I feel like it's better than nothing.
frame was unused so let's remove it. Signed-off-by: Sébastien Han <seb@redhat.com>
Previously when the --name was used, the code will still go through the initial list. Now if --name is passed, only this user will be used to upload crashes. Signed-off-by: Sébastien Han <seb@redhat.com>
Now, the script can run with --log-level DEBUG to enable DEBUG level logging. Signed-off-by: Sébastien Han <seb@redhat.com>
This is not perfect, but we have seen cases where the CLI returns 0 even on failure. For instance: ```sh [root@rook-ceph-crashcollector-compute-1-66bdfbd886-d2zcd /]# ceph -n client.crash crash post -i /var/lib/ceph/crash/2021-06-28T07\:47\:37.859766Z_6ffb119c-930e-4047-9cfa-a92af783cdd0/meta malformed crash metadata: time data '2021-06-28T07:47:37.859766' does not match format '%Y-%m-%d %H:%M:%S.%f' [root@rook-ceph-crashcollector-compute-1-66bdfbd886-d2zcd /]# echo $? 0 ``` So until we find the root cause, let's mitigate and perhaps accomodate for futur similar issues. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
crash-various-fixes
branch
from
8a89e01
to
a77b47e
Compare
|
jenkins test make check |
djgalloway
pushed a commit
that referenced
this pull request
Jul 8, 2021
src/ceph-crash.in: various enhancements and fixes
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox