pacific: pacific: client: abort after MDS blocklist #42070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client segfaults when trying to infer which mds rank a connection reset call is coming from. It does this by iterating `mds_sessions` and checking the mds addr (in mdsmap) to the `Connection *`. However, cases where the mds is blocklisted, the client receives an updated mdsmap in which the corresponding mds is not in `up` set thereby resulting in a segfault when calling `mdsmap->get_addrs` since it expects that the mds should be in `up` state. Note that this leaves the `Connection *` as it is and does not clean it up. That needs to fixed separately probably by maintaining a map of `Connection *` to mds rank for lookup. Fixes: http://tracker.ceph.com/issues/50530 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 951483f)
yuriw
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/51324