qa: use run_shell_payload to avoid sudo #42075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check |
rishabh-d-dave
approved these changes
Jun 29, 2021
|
Unfortunately I was wrong in that this does not avoid sudo: From: https://pulpito.ceph.com/pdonnell-2021-06-28_22:59:28-fs-master-distro-basic-smithi/ I think this patch is still good as it avoids the awkward |
batrick
force-pushed
the
i51417
branch
2 times, most recently
from
6e5150a
to
30d0236
Compare
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 29, 2021
* refs/pull/42075/head: qa: avoid using sudo for regular test artifacts qa: use run_shell_payload to avoid sudo
batrick
force-pushed
the
i51417
branch
2 times, most recently
from
83a4bef
to
433b4b6
Compare
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 30, 2021
* refs/pull/42075/head: qa: avoid using sudo for regular test artifacts qa: convert mount calls to mount_wait qa: use run_shell_payload to avoid sudo
"run_shell" adds 'sudo' which runs afoul of new security protections on Ubuntu 20.04. Fixes: https://tracker.ceph.com/issues/51417 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
These tests want to immediately use the mount anyway. But the main
problem is, without waiting for the mount to complete, the command:
chmod 1777 /path/to/mount
is not run so the mount cannot be written to by normal users without
sudo.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jul 2, 2021
* refs/pull/42075/head: qa: avoid using sudo for regular test artifacts qa: convert mount calls to mount_wait qa: use run_shell_payload to avoid sudo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"run_shell" adds 'sudo' which runs afoul of new security protections on
Ubuntu 20.04.
Fixes: https://tracker.ceph.com/issues/51417
Signed-off-by: Patrick Donnelly pdonnell@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox