nautilus: pacific: pybind/ceph_volume_client: stat on empty string #42162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batrick
added
cephfs
This _mkdir_p should never have worked as the first directory it tries
to stat/mkdir is "", the empty string. This causes an assertion in the
client. I'm not sure how this code ever functioned without causing
faults. They look like:
2021-07-01 02:15:04.449 7f7612b5ab80 3 client.178735 statx enter (relpath want 2047)
The assertion is caused by a C++ exception:
/usr/include/c++/8/string_view:172: constexpr const _CharT& std::basic_string_view<_CharT, _Traits>::operator[](std::basic_string_view<_CharT, _Traits>::size_type) const [with _CharT = char$_Traits = std::char_traits<char>; std::basic_string_view<_CharT, _Traits>::size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed.
Aborted (core dumped)
Where relpath is just the path passed to Client::stat.
This commit only applies to Pacific and older because master no longer
has this library.
Fixes: https://tracker.ceph.com/issues/51492
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0fb05ae)
|
@yuriw thanks! |
|
Changes LGTM, have been tested on a manila environment - Thank you for making and back porting this fix, @batrick! |
|
Awesome! looks great! |
ajarr
approved these changes
Jul 2, 2021
|
Awesome, thanks for the quick fix Patrick! |
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jul 28, 2021
* Update openstack-tempest-skiplist from branch 'master'
to 3bcf24eb9d0e11a0a054944d1d0832468820872b
- Merge "Revert "Skip manila_tempest_tests.tests.api.test_shares.SharesNFSTest test""
- Revert "Skip manila_tempest_tests.tests.api.test_shares.SharesNFSTest test"
This reverts commit 021b8a77a670859df5abf8a127de5e303a58fc66.
Reason for revert: fixed with ceph/ceph#42162
Related-Bug: 1934879
Change-Id: I20f8ce51c6bb59207ef82bd7786bc788c9fd313f
dsariel
pushed a commit
to openstack-k8s-operators/ci-framework
that referenced
this pull request
Mar 31, 2023
… test" This reverts commit 021b8a77a670859df5abf8a127de5e303a58fc66. Reason for revert: fixed with ceph/ceph#42162 Related-Bug: 1934879 Change-Id: I20f8ce51c6bb59207ef82bd7786bc788c9fd313f
openstack-mirroring
pushed a commit
to openstack-archive/openstack-tempest-skiplist
that referenced
this pull request
Feb 25, 2024
… test" This reverts commit 021b8a7. Reason for revert: fixed with ceph/ceph#42162 Related-Bug: 1934879 Change-Id: I20f8ce51c6bb59207ef82bd7786bc788c9fd313f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/51493