Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: handle empty path strings #42163

Closed
wants to merge 2 commits into from
Closed

client: handle empty path strings #42163

wants to merge 2 commits into from

Conversation

batrick
Copy link
Member

@batrick batrick commented Jul 2, 2021 •
edited by tchaikov

  • add tests

@batrick batrick added the cephfs Ceph File System label Jul 2, 2021
batrick
batrick commented Jul 2, 2021
View reviewed changes
src/include/filepath.h

void set_path(std::string_view s, inodeno_t b) {
ceph_assert(s.size() > 0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not correct, I think empty paths are permitted when specifying the inode.

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jan 9, 2022
@batrick
include/filepath: assert on empty string
634ce3f 
A filepath must not be empty.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
client: check for empty paths
4304463 
and return ENOENT.

Fixes: https://tracker.ceph.com/issues/51495
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@stale stale bot removed the stale label Jan 16, 2022
@djgalloway djgalloway changed the base branch from master to main July 3, 2022 00:00
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 1, 2022
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cephfs Ceph File System stale
Projects
None yet
Milestone
No milestone
1 participant
@batrick