Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: grep kernel logs for kclient warnings/failures to fail a test #42193

Closed
wants to merge 1 commit into from

Conversation

kotreshhr
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/50150
Signed-off-by: Kotresh HR khiremat@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the tests label Jul 6, 2021
@kotreshhr
Copy link
Contributor Author

@batrick Does the /var/log/kern.log truncates before every run ?

@kotreshhr
Copy link
Contributor Author

jenkins test make check

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. @jtlayton is there a decent way to synthetically generate these failures so we can verify this grep works as advertised?

@batrick batrick requested a review from jtlayton July 7, 2021 16:42
@batrick batrick added cephfs Ceph File System needs-review labels Jul 7, 2021
@jtlayton
Copy link
Contributor

jtlayton commented Jul 7, 2021

Crashing the box is pretty simple if you have sysrq turned on. See:

https://www.kernel.org/doc/html/latest/admin-guide/sysrq.html

It may need to be enabled on the box though (see the above doc on how to do that). Then, you can just do echo c > /proc/sysrq-trigger. The other ones are harder to generate on their own.

@batrick
Copy link
Member

batrick commented Jul 7, 2021

Sure but what about the others? It'd be nice to test for each one to know it works.

@batrick batrick added the krbd label Jul 7, 2021
@jtlayton
Copy link
Contributor

jtlayton commented Jul 7, 2021

Actually...you may be able to just inject the messages you want to catch into /dev/kmsg:

echo "BUG:" > /proc/kmsg

...and it should show up in the kernel's ring buffer.

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idryomov this will affect your krbd testing too. Any patterns you would like to add?

qa/tasks/ceph.py Show resolved Hide resolved
qa/tasks/ceph.py Outdated Show resolved Hide resolved
qa/tasks/ceph.py Outdated Show resolved Hide resolved
qa/tasks/ceph.py Outdated Show resolved Hide resolved
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this, see https://github.com/ceph/teuthology/blob/master/teuthology/task/internal/syslog.py#L100-L143. If it's broken let's fix it instead of duplicating the functionality in the ceph task.

@batrick batrick marked this pull request as draft July 15, 2021 22:06
@kotreshhr
Copy link
Contributor Author

We already have this, see https://github.com/ceph/teuthology/blob/master/teuthology/task/internal/syslog.py#L100-L143. If it's broken let's fix it instead of duplicating the functionality in the ceph task.

Pushed a PR in teuthology repo ceph/teuthology#1666

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jan 9, 2022
@batrick
Copy link
Member

batrick commented Jan 10, 2022

@stale stale bot removed the stale label Jan 10, 2022
@vshankar
Copy link
Contributor

Superseded by ceph/teuthology#1666

@vshankar vshankar closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System krbd tests
Projects
None yet
5 participants