doc/dev/cephadm: Define variables #42209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/47142 Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
tchaikov
reviewed
Jul 8, 2021
| Note regarding different variables used in the code | ||
| =================================================== | ||
|
|
||
| * a ``service_type`` is something like mon, mgr, alertmanager etc defined |
There was a problem hiding this comment.
how about using
.. describe:: service_type
something like mon, mgr, alertmanager etc defined in ``ServiceSpec``which is rendered like items like "waiting_for_healthy" in https://docs.ceph.com/en/latest/dev/crimson/osd/ .
There was a problem hiding this comment.
tbh, I don't really care. this is just the developer documentation.
adk3798
approved these changes
Jul 9, 2021
|
|
||
| * a ``service_type`` is something like mon, mgr, alertmanager etc defined | ||
| in ``ServiceSpec`` | ||
| * a ``service_id`` is the name of the service. Some services don't have |
There was a problem hiding this comment.
possible suggestion, what you have now is correct
Suggested change
| * a ``service_id`` is the name of the service. Some services don't have | |
| * a ``service_id`` is the name for an instance of a service. Services only allowed | |
| one instance per cluster don't have a service id (e.g. mgr, mon, prometheus). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/47142
Signed-off-by: Sebastian Wagner sewagner@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox