Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/standalone: Add missing cleanups after completion of a subset of osd and scrub tests. #42234

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

sseshasa
Copy link
Contributor

@sseshasa sseshasa commented Jul 7, 2021

  1. Add missing teardowns to the tests in the following osd tests:
  • osd/osd-force-create.sh
  • osd/osd-reuse-id.sh
  • osd/pg-split-merge.sh
  1. Add missing teardown to the following tests within osd-scrub-repair.sh:
  • TEST_periodic_scrub_replicated()
  • TEST_scrub_warning()
  • TEST_request_scrub_priority()

Fixes: https://tracker.ceph.com/issues/51580
Signed-off-by: Sridhar Seshasayee sseshasa@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the core label Jul 7, 2021
@sseshasa
Copy link
Contributor Author

sseshasa commented Jul 7, 2021

Pulpito run of the OSD Tests:
https://pulpito.ceph.com/sseshasa-2021-07-07_19:19:28-rados:standalone-master-distro-basic-smithi/
1 unrelated dead test.

Pulpito run of the Scrub Tests:
https://pulpito.ceph.com/sseshasa-2021-07-07_19:22:19-rados:standalone-master-distro-basic-smithi/

Scrub Failures are unrelated to the changes in this PR:
6258018: Updated https://tracker.ceph.com/issues/49961
6258022: Updated https://tracker.ceph.com/issues/50245
6258019: Added new tracker: https://tracker.ceph.com/issues/51581

@sseshasa sseshasa added the tests label Jul 7, 2021
@sseshasa sseshasa marked this pull request as ready for review July 7, 2021 22:28
Copy link
Contributor

@ronen-fr ronen-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we restructure the init/teardown in the 2nd commit the same way it was handled in the 1st (i.e. in the main loop)?

@sseshasa
Copy link
Contributor Author

sseshasa commented Jul 8, 2021

Could we restructure the init/teardown in the 2nd commit the same way it was handled in the 1st (i.e. in the main look)?

Sure, I can do that. I will update the PR soon. Thanks!

Update:
Pulpito run with the above additional Scrub changes:
https://pulpito.ceph.com/sseshasa-2021-07-08_08:02:35-rados:standalone-master-distro-basic-smithi/

The following files and tests in them did not teardown the
cluster after a test completed.

1. osd/osd-force-create.sh
2. osd/osd-reuse-id.sh
3. osd/pg-split-merge.sh

This wouldn't cause issues if the tests are run individually. But when
running all the tests in the files mentioned above, it could introduce
unexpected test failures down the line. For e.g., multiple tests may
create pools with same name and if they are not cleaned up properly, this
could result in unexpected failures in a subsequent test.

Fixes: https://tracker.ceph.com/issues/51580
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
…tests

Tests identified with missing teardown within osd-scrub-repair.sh:
  1. TEST_periodic_scrub_replicated()
  2. TEST_scrub_warning()
  3. TEST_request_scrub_priority()

Centralize setup and teardown within the run() function for all the tests.

Fixes: https://tracker.ceph.com/issues/51580
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
@sseshasa sseshasa force-pushed the wip-fix-standalone-cleanups branch from 0095c4f to 84cab65 Compare July 8, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants