osd: fix to recover adjacent clone when set_chunk is called #42279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jul 12, 2021
tchaikov
reviewed
Jul 12, 2021
tchaikov
reviewed
Jul 12, 2021
src/osd/PrimaryLogPG.cc
Outdated
| @@ -3445,7 +3445,18 @@ int PrimaryLogPG::get_manifest_ref_count(ObjectContextRef obc, std::string& fp_o | |||
|
|
|||
| bool PrimaryLogPG::recover_adjacent_clones(ObjectContextRef obc, OpRequestRef op) | |||
| { | |||
| if (!obc->obs.oi.manifest.is_chunked() || !obc->ssc || !obc->ssc->snapset.clones.size()) { | |||
| bool has_manifest_op = false; | |||
There was a problem hiding this comment.
might want to move the definition of has_manifest_op closer to where it is set.
set_chunk needs adjacent clones to calculate reference count fixes: https://tracker.ceph.com/issues/51627 Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
|
@tchaikov Thanks for your comment. Done. |
tchaikov
approved these changes
Jul 14, 2021
|
@myoungwon do we need to backport this fix to pacific? |
|
@neha-ojha Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_chunk needs adjacent clones to calculate reference count.
Therefore, check if adjacent clones is unreadable even if
the head object is not manifest object.
fixes: https://tracker.ceph.com/issues/51627
Signed-off-by: Myoungwon Oh myoungwon.oh@samsung.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox