cephadm: fetch the real selinux status #42290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javicacheiro
force-pushed
the
fix_cephadm_selinux
branch
from
83f59aa
to
1fd7917
Compare
adk3798
reviewed
Jul 13, 2021
|
can you copy the essential parts of the tracker issue into the commit message? I'd like to be able to get a reason for this change, without looking at the tracker issue |
javicacheiro
force-pushed
the
fix_cephadm_selinux
branch
from
9c8351a
to
892d1d8
Compare
Done! |
adk3798
approved these changes
Jul 14, 2021
|
jenkins test make check |
adk3798
reviewed
Jul 14, 2021
The HostFacts should return the **actual** selinux mode in which the kernel is running. The actual mode can be different from the one in the configuration if the server has not been rebooted or if the mode was changed after boot using setenforce. Instead of reading _selinux_path_list we should look at the output of sestatus or getenforce. The _selinux_path_list attribute is no longer needed. Fixes: https://tracker.ceph.com/issues/51632 Signed-off-by: Javier Cacheiro <javier.cacheiro.lopez@cesga.es>
javicacheiro
force-pushed
the
fix_cephadm_selinux
branch
from
95e5b3e
to
c3c79fc
Compare
dsavineau
approved these changes
Jul 14, 2021
|
all tests passed in teuthology run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch the real selinux status.
The mode in the configuration file and the actual mode can be different so we can not simply trust the configuration file, we have to check the real selinux status.
Fixes: https://tracker.ceph.com/issues/51632
Signed-off-by: Javier Cacheiro javier.cacheiro.lopez@cesga.es
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox