Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Cluster Creation Workflow followups #42296

Merged
merged 1 commit into from Jul 19, 2021
Merged

mgr/dashboard: Cluster Creation Workflow followups #42296

merged 1 commit into from Jul 19, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Jul 13, 2021 •
edited

  1. Fix bug in the modal where going forward one step on the wizard and coming back opens up the add host modal.
  2. Renamed Create Cluster to Expand Cluster as per the discussions
  3. A skip confirmation modal to warn the user when he tries to skip the cluster creation
  4. Adapted all the tests
  5. Did some UI improvements like fixing and aligning the styles, colors..
    new

UI improvements
new

Skip Confirmation Modal
skipmodal

Fixes: https://tracker.ceph.com/issues/51640
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 added this to In progress in Dashboard via automation Jul 13, 2021
@nizamial09 nizamial09 requested a review from a team July 13, 2021 08:05
@nizamial09 nizamial09 requested a review from a team as a code owner July 13, 2021 08:05
@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch 2 times, most recently from 5c8336a to 389b477 Compare July 14, 2021 08:14
@github-actions github-actions bot added the core label Jul 14, 2021
@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch from 389b477 to c207cdf Compare July 14, 2021 08:16
@nizamial09
Copy link
Member Author 

Running:  orchestrator/06-cluster-welcome-page.e2e-spec.ts                                (1 of 1)


  Create cluster page
    ✓ should fail to create cluster (2663ms)
    ✓ should skip to dashboard landing page (1474ms)


  2 passing (4s)

@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch from c207cdf to 4b86c90 Compare July 15, 2021 10:10
@nizamial09 nizamial09 mentioned this pull request Jul 15, 2021
Merged
3 tasks
Dashboard automation moved this from In progress to Reviewer approved Jul 15, 2021
@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch 2 times, most recently from cc4654b to 562bdc8 Compare July 15, 2021 17:32
@nizamial09
Copy link
Member Author

Removed the e2e tests since those are being covered separately in #41951

avanthakkar
avanthakkar approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch from 562bdc8 to b66f9db Compare July 19, 2021 09:01
@nizamial09 nizamial09 requested a review from Waadkh7 July 19, 2021 09:02
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Jul 19, 2021
@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch from b66f9db to 987873e Compare July 19, 2021 13:11
@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch from 987873e to 54ab5c6 Compare July 19, 2021 13:41
Dashboard automation moved this from Ready-to-merge to Reviewer approved Jul 19, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Jul 19, 2021
@nizamial09
mgr/dashboard: Cluster Creation Workflow followups
130a3b0 
1. Fix bug in the modal where going forward one step on the wizard and coming back opens up the add host modal.
2. Rename Create Cluster to Expand Cluster as per the discussions
3. A skip confirmation modal to warn the user when he tries to skip the
   cluster creation
4. Adapted all the tests
5. Did some UI improvements like fixing and aligning the styles,
   colors..

Fixes: https://tracker.ceph.com/issues/51640
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 force-pushed the cluster-creation-add-hosts-followups branch from 54ab5c6 to 130a3b0 Compare July 19, 2021 14:28
@epuertat epuertat merged commit d666dc3 into ceph:feature-50336-cluster-creation-wizard Jul 19, 2021
Dashboard automation moved this from Ready-to-merge to Done Jul 19, 2021
@epuertat epuertat deleted the cluster-creation-add-hosts-followups branch July 19, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@epuertat epuertat epuertat approved these changes

@Waadkh7 Waadkh7 Waadkh7 approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14

Assignees
No one assigned
Labels
bug-fix core dashboard needs-review pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
5 participants
@nizamial09 @alfonsomthd @avanthakkar @epuertat @Waadkh7