rgw: bucket index list can produce I/O errors #42404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancich
force-pushed
the
wip-broken-list-plain-entries
branch
from
1b84098
to
bc6a615
Compare
mattbenjamin
approved these changes
Jul 19, 2021
| * list_plain_entries(). It's convenient that "Both" be in between the | ||
| * others so we can use "<= Both" or ">= Both" logic. | ||
| */ | ||
| enum class PlainEntriesRegion { |
There was a problem hiding this comment.
this does seem to help readability
A recent PR that helped address the issue of non-ascii plain entries didn't cover all the bases, allowing I/O errors to be produced in some circumstances during a bucket index list (i.e., `radosgw-admin bi list ...`). This fixes those issue and does some additional clean-up. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
ivancich
force-pushed
the
wip-broken-list-plain-entries
branch
from
bc6a615
to
e714f0d
Compare
3 tasks
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR that helped address the issue of non-ascii plain entries
didn't cover all the bases, allowing I/O errors to be produced in some
circumstances during a bucket index list (i.e.,
radosgw-admin bi list ...).This fixes those issue and does some additional clean-up.
Signed-off-by: J. Eric Ivancich ivancich@redhat.com
Fixes: https://tracker.ceph.com/issues/51429