pacific: rpm: drop use of $FIRST_ARG in ceph-immutable-object-cache #42480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of $FIRST_ARG was probably required because the SUSE-specific %service_* rpm macros were playing tricks on the shell positional parameters. This is bad practice and error-prone, so let's assume that no macros should do that anymore and hence it's safe to assume that positional parameters remain unchanged after any rpm macro call. Thanks to Franck Bui for providing the original patch 926433f that this patch is modeled after. NOTE: the use of FIRST_ARG had already been eliminated by 926433f but was re-introduced later by 9466d70 Fixes: 9466d70 Fixes: https://tracker.ceph.com/issues/51797 Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 1cb84a1)
tchaikov
approved these changes
Jul 26, 2021
idryomov
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/51836
backport of #42452
parent tracker: https://tracker.ceph.com/issues/51797
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh