Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw:If the endpoint of the event notification does not respond, the process will be stuck. #42497

Closed
wants to merge 1 commit into from

Conversation

ybwang0211
Copy link
Contributor

rgw:If the endpoint of the event notification does not respond, the process will be stuck.

We use the function of uploading objects and set an event notification for the bucket. However, due to the wrong endpoint setting, the file cannot be uploaded and is stuck all the time without reporting an error.
So we added the CURLOPT_CONNECTTIMEOUT parameter to control the connection timeout.

fix: https://tracker.ceph.com/issues/51855

Signed-off-by: wangyingbin ybwang0211@163.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

…rocess will be stuck.

We use the function of uploading objects and set an event notification for the bucket. However, due to the wrong endpoint setting, the file cannot be uploaded and is stuck all the time without reporting an error.
So we added the CURLOPT_CONNECTTIMEOUT parameter to control the connection timeout.

fix: https://tracker.ceph.com/issues/51855

Signed-off-by: wangyingbin <ybwang0211@163.com>
@github-actions github-actions bot added the rgw label Jul 27, 2021
@cbodley
Copy link
Contributor

cbodley commented Jul 29, 2021

from https://curl.se/libcurl/c/CURLOPT_CONNECTTIMEOUT.html, it sounds like there already is a default connection timeout of 300 seconds

@cbodley cbodley requested a review from yuvalif July 29, 2021 14:20
@yuvalif
Copy link
Contributor

yuvalif commented Aug 2, 2021

from https://curl.se/libcurl/c/CURLOPT_CONNECTTIMEOUT.html, it sounds like there already is a default connection timeout of 300 seconds

300 seconds is probably too high, at least for the case of notifications.
make sense to change that to lower value, but should be don't for the case of notifications, and not in the general case.
see: https://github.com/ceph/ceph/blob/master/src/rgw/rgw_pubsub_push.cc#L138

we should probably also change the HTTP request timeout not the be the default (0 - infinite), to some lower values (5 sec?)
note that notifications are usually small (~1KB), and keeping a small timeout would make sense.

@cbodley
Copy link
Contributor

cbodley commented Nov 18, 2021

ping @ybwang0211

@djgalloway djgalloway changed the base branch from master to main July 2, 2022 00:00
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 31, 2022
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants