rgw: add the condition of lock mode conversion to PutObjRentention #42505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzbxqt327
changed the title
wzbxqt327
force-pushed
the
put_obj_rentention
branch
3 times, most recently
from
5515ead
to
24d18a8
Compare
|
hi @cbodley do you mind help review this? |
cbodley
reviewed
Aug 2, 2021
Signed-off-by: wangzhong <wangzhong@cmss.chinamobile.com>
wzbxqt327
force-pushed
the
put_obj_rentention
branch
from
24d18a8
to
585eae4
Compare
|
thanks @wzbxqt327, i opened https://tracker.ceph.com/issues/52037 to make sure this fix gets backported. can you please add this line to your commit message? |
|
hi, @cbodley，I have added it |
cbodley
approved these changes
Aug 4, 2021
|
thanks @wzbxqt327! |
This was referenced Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the use and test of amazon S3, I found that when the lock mode is COMPLIANCE, it should not be changed to GOVERNANCE. When the lock mode is GOVERNANCE, it can be changed to COMPLIANCE only when the bypass is set.
Fixes: https://tracker.ceph.com/issues/52037
Signed-off-by: wangzhong wangzhong@cmss.chinamobile.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox