win32_deps_build.sh: bump snappy version to 1.1.9 #42516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
approved these changes
Jul 28, 2021
tchaikov
force-pushed
the
wip-win32-snappy
branch
from
22997ca
to
0c5a7ff
Compare
|
changelog
|
The snappy project made the following change in snappy.h between version 1.1.8 and 1.1.9: < bool GetUncompressedLength(Source* source, uint32_t* result); --- > bool GetUncompressedLength(Source* source, uint32* result); This causes Ceph to FTBFS with snappy 1.1.9. Thanks to Chris Denice for bringing this to our attention via Redmine. Fixes: https://tracker.ceph.com/issues/50934 Signed-off-by: Nathan Cutler <ncutler@suse.com>
in snappy, the commit of 26102a0c66175bc39edbf484c994a21902e986dc fixes the SNAPPY_VERSION generation. and this commit was included by v1.1.8 and v1.1.9. also, in v1.1.9, a change was introduced, where the function signature was changed, and more importantly, this change is not backward compatible: < bool GetUncompressedLength(Source* source, uint32_t* result); --- > bool GetUncompressedLength(Source* source, uint32* result); see also, https://tracker.ceph.com/issues/50934 so we check SNAPPY_VERSION to tell if we should use `uint32_t` or `uint32`. in this change, snappy version used to build win32 client is bumped to the latest stable version, v1.1.9, to include the fix of SNAPPY_VERSION. this paves the road to fix of https://tracker.ceph.com/issues/50934 Signed-off-by: Kefu Chai <kchai@redhat.com>
no need to clone the whole repo, just clone the tip of the specified tag. this saves the bandwidth, disk IO and precious time. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-win32-snappy
branch
from
0c5a7ff
to
1d5b07a
Compare
|
changelog
|
|
@tchaikov Please update https://tracker.ceph.com/issues/50934 when this gets merged, so I can prepare the pacific backport. |
|
@smithfarm sure, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/50934