Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix ssl cert validation for rgw service creation #42554

Merged
merged 1 commit into from Aug 4, 2021
Merged

mgr/dashboard: fix ssl cert validation for rgw service creation #42554

merged 1 commit into from Aug 4, 2021

Conversation

avanthakkar
Copy link
Contributor

Fixes: https://tracker.ceph.com/issues/51965
Signed-off-by: Avan Thakkar athakkar@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@avanthakkar avanthakkar requested a review from a team as a code owner July 29, 2021 23:11
@avanthakkar avanthakkar added this to In progress in Dashboard via automation Jul 29, 2021
@avanthakkar avanthakkar requested review from pereman2 and removed request for a team July 29, 2021 23:11
@avanthakkar avanthakkar changed the title mgr/dashboard: fix ssl cert validation for rgw service creation [WIP] mgr/dashboard: fix ssl cert validation for rgw service creation Jul 30, 2021
@avanthakkar avanthakkar force-pushed the fix-rgw-ssl-cert-validation branch 4 times, most recently from 9d21fea to cfbc89a Compare July 30, 2021 15:06
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@avanthakkar
Copy link
Contributor Author

jenkins test make check

@avanthakkar avanthakkar changed the title [WIP] mgr/dashboard: fix ssl cert validation for rgw service creation mgr/dashboard: fix ssl cert validation for rgw service creation Aug 2, 2021
@avanthakkar
Copy link
Contributor Author

jenkins retest this please

@avanthakkar avanthakkar force-pushed the fix-rgw-ssl-cert-validation branch 3 times, most recently from 78dcff4 to 9624eb8 Compare August 2, 2021 12:09
Dashboard automation moved this from In progress to Reviewer approved Aug 2, 2021
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

Dashboard automation moved this from Reviewer approved to Review in progress Aug 2, 2021
@alfonsomthd
Copy link
Contributor

jenkins test dashboard

Dashboard automation moved this from Review in progress to Reviewer approved Aug 3, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Aug 3, 2021
Dashboard automation moved this from Ready-to-merge to Review in progress Aug 3, 2021
epuertat
epuertat approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing my comments.

...dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.spec.ts Outdated Show resolved Hide resolved
Dashboard automation moved this from Review in progress to Reviewer approved Aug 3, 2021
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@avanthakkar
Copy link
Contributor Author

jenkins test make check

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@epuertat epuertat merged commit 81141b9 into ceph:master Aug 4, 2021
Dashboard automation moved this from Reviewer approved to Done Aug 4, 2021
@epuertat epuertat deleted the fix-rgw-ssl-cert-validation branch August 4, 2021 11:37
@avanthakkar avanthakkar mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@epuertat epuertat epuertat approved these changes

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@pereman2 pereman2 Awaiting requested review from pereman2

Assignees
No one assigned
Labels
dashboard needs-review pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
5 participants
@avanthakkar @alfonsomthd @epuertat @aaSharma14 @nizamial09