mgr/dashboard: Create OSDs section in cluster creation wizard #42583

aaSharma14 · 2021-08-02T11:37:29Z

Create OSDs section in cluster creation wizard

Fixes: https://tracker.ceph.com/issues/51991
Signed-off-by: Aashish Sharma aasharma@redhat.com

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.ts

aaSharma14 · 2021-08-06T08:17:05Z

jenkins test make check

nizamial09

IMHO, I don't see a point in showing the OSD List table. OSD's wont be showing up in that table unless it is added to the cluster. And osds are only added only after adding the host (In our case, after exiting the hosts out of maintenance/removing the _no_schedule label).

My suggestion will be to use the osd-creation-form instead of the list. The whole point of showing this list is to preview the user of the output and we get that information from the osd-creation-form itself as a preview.

aaSharma14 · 2021-08-09T11:58:19Z

jenkins test dashboard cephadm

aaSharma14 · 2021-08-09T12:12:27Z

IMHO, I don't see a point in showing the OSD List table. OSD's wont be showing up in that table unless it is added to the cluster. And osds are only added only after adding the host (In our case, after exiting the hosts out of maintenance/removing the _no_schedule label).

My suggestion will be to use the osd-creation-form instead of the list. The whole point of showing this list is to preview the user of the output and we get that information from the osd-creation-form itself as a preview.

I think osds can be created in _no_schedule mode. @avanthakkar Do you have any idea?

votdev

Sorry for hijacking this PR, but while testing it the following things come to my mind:

There is too much Expand Cluster shown on this page. The breadcrumb in the upper left corner should be removed, it is pretty useless here on this page.
Change Expand Cluster in the red button to Continue or Start.

IMO Expand Cluster is also too much mentioned here. Remove the breadcrumb, it is also pretty useless here. I'm aware of that all pages display the breadcrumb in Ceph Dashboard, but IMO a wizard is something different than a regular page.

I suggest to rename the red Expand cluster button to Finish or Apply.

votdev · 2021-08-09T13:52:56Z

...ind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.html

+          <h4 class="title"
+              i18n>Create OSDs</h4>
+          <br>
+          <cd-osd-list [clusterCreation]="true"></cd-osd-list>


Maybe add an attribute to hide the title, because showing it twice doesn't look nice. I guess the user knows that they are on the Create OSD page because the navigation on the left shows it. The same applies to the Add Hosts wizard page.

@votdev In the particular case I think that the title is helpful as yo can easily overlook the left column.

nizamial09 · 2021-08-17T08:52:06Z

@votdev @aaSharma14 These comments are being followed up on this PR. #42557

...frontend/cypress/integration/orchestrator/workflow/03-create-cluster-create-osds.e2e-spec.ts

nizamial09

LGTM! One thing I noticed is that after selecting the devices in the create osd section, I click next and came back to Previous step to see that the osd device preview is gone. But the drive-group spec is kept and previously selected storage information is still shown in Review Section. (If I change it and select new spec, it gets updated too). And it even created OSDs as expected. So only a minor thing to improve.

Thank you for addressing all my reviews. Great work @aaSharma14

src/pybind/mgr/dashboard/frontend/src/app/shared/services/wizard-steps.service.ts

avanthakkar · 2021-08-30T13:28:23Z

.../dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster-review.component.html

+              class="bold">Storage Capacity</td>
+          <td><span i18n
+                    *ngIf="filteredDevices && capacity">Number of devices: {{ filteredDevices.length }}. Raw capacity:
+            {{ capacity | dimlessBinary }}.</span></td>


This doesn't seem right to me. Maybe just Storage capaticy: x GiB or acc. to @pcuzner suggestion
"just use a table showing columns for hdd, flash showing sum for the total capacity and drive count per type - so you can do a quick visual check "

I think Something like this may work too: 2xHDD xGiB, 3xFlash yGiB
what u think? @nizamial09 @epuertat

I think that could work. Also I believe you are taking care of this in a separate PR right @avanthakkar ? So its best to do it separately on that PR where you are following up on the review page (#42488) because I believe this PR has went through a lot to get here. Does that works for you @avanthakkar ?

Also I like separating them into different columns better. Its more visually catchy.

I think that could work. Also I believe you are taking care of this in a separate PR right @avanthakkar ? So its best to do it separately on that PR where you are following up on the review page (#42488) because I believe this PR has went through a lot to get here. Does that works for you @avanthakkar ?

I've already introduced the review section changes in my current PR for gather facts itself. But yeah I agree some minor things can be introduced in later PR, maybe having a general expand cluster workflow remaining cleanups.

pereman2

Working fine. One thing that worries me is when adding primary devices you have to select them with filters. I don't remember if this was discussed or something, but why isn't there a way to select with just a click in addition of using filters.

avanthakkar

Tested locally and works perfect! Great job @aaSharma14 @nizamial09 !!

nizamial09 · 2021-08-30T18:51:15Z

but why isn't there a way to select with just a click in addition of using filters.

Yup, I am actually trying to propose another design for it. Next week or so I'll do one.

nizamial09 · 2021-08-31T06:41:13Z

jenkins test dashboard cephadm

avanthakkar · 2021-08-31T07:39:47Z

jenkins test dashboard cephadm

aaSharma14 · 2021-08-31T09:54:35Z

jenkins test api

Create OSDs section in cluster creation wizard Fixes: https://tracker.ceph.com/issues/51991 Signed-off-by: Aashish Sharma <aasharma@redhat.com>

nizamial09 · 2021-08-31T12:32:36Z

jenkins test dashboard cephadm

nizamial09 · 2021-08-31T12:58:12Z

@epuertat, cephadm dashboard test failure is because of https://tracker.ceph.com/issues/52407

Locally, along with the fix from Sebastian, its passing.

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  orchestrator/workflow/01-create-clu      00:04        2        2        -        -        - │
  │    ster-welcome-page.e2e-spec.ts                                                               │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  orchestrator/workflow/02-create-clu      00:33        6        6        -        -        - │
  │    ster-add-host.e2e-spec.ts                                                                   │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  orchestrator/workflow/03-create-clu      00:04        2        2        -        -        - │
  │    ster-create-osds.e2e-spec.ts                                                                │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  orchestrator/workflow/03-create-clu      00:05        4        4        -        -        - │
  │    ster-review.e2e-spec.ts                                                                     │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  orchestrator/workflow/04-cluster-ch      01:56        5        5        -        -        - │
  │    eck.e2e-spec.ts                                                                             │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        02:44       19       19        -        -        -

fixed

aaSharma14 requested a review from a team as a code owner August 2, 2021 11:37

aaSharma14 requested review from pereman2, aaryanporwal and cypherean and removed request for a team August 2, 2021 11:37

github-actions bot added dashboard pybind labels Aug 2, 2021

aaSharma14 force-pushed the add-osd-cluster-creation branch from 6503c4d to 8a3fa0c Compare August 2, 2021 11:47

aaSharma14 requested review from nizamial09, epuertat, avanthakkar and alfonsomthd August 2, 2021 11:48

aaSharma14 added this to In progress in Dashboard via automation Aug 2, 2021

avanthakkar reviewed Aug 4, 2021

View reviewed changes

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.ts Outdated Show resolved Hide resolved

aaSharma14 force-pushed the add-osd-cluster-creation branch 2 times, most recently from 4e6abf1 to b53698b Compare August 5, 2021 05:46

nizamial09 reviewed Aug 9, 2021

View reviewed changes

aaSharma14 force-pushed the add-osd-cluster-creation branch from 7a5cafb to 9e4add7 Compare August 9, 2021 11:42

votdev requested changes Aug 9, 2021

View reviewed changes

Dashboard automation moved this from In progress to Review in progress Aug 9, 2021

votdev previously requested changes Aug 9, 2021

View reviewed changes

aaSharma14 force-pushed the add-osd-cluster-creation branch from d259061 to c7bda38 Compare August 20, 2021 06:46

pereman2 reviewed Aug 20, 2021

View reviewed changes

...frontend/cypress/integration/orchestrator/workflow/03-create-cluster-create-osds.e2e-spec.ts Outdated Show resolved Hide resolved

aaSharma14 force-pushed the add-osd-cluster-creation branch 3 times, most recently from ac113a2 to 8b4acdc Compare August 24, 2021 06:33

github-actions bot added the pybind label Aug 26, 2021

aaSharma14 force-pushed the add-osd-cluster-creation branch from c380bcb to 05379c8 Compare August 26, 2021 08:11

nizamial09 approved these changes Aug 26, 2021

View reviewed changes

nizamial09 reviewed Aug 30, 2021

View reviewed changes

src/pybind/mgr/dashboard/frontend/src/app/shared/services/wizard-steps.service.ts Outdated Show resolved Hide resolved

aaSharma14 force-pushed the add-osd-cluster-creation branch 2 times, most recently from e527bc7 to a70aa71 Compare August 30, 2021 12:34

avanthakkar reviewed Aug 30, 2021

View reviewed changes

pereman2 approved these changes Aug 30, 2021

View reviewed changes

avanthakkar approved these changes Aug 30, 2021

View reviewed changes

avanthakkar moved this from In progress to Review in progress in Dashboard Aug 30, 2021

aaSharma14 force-pushed the add-osd-cluster-creation branch 2 times, most recently from c1ad477 to 35c5aae Compare August 31, 2021 05:12

aaSharma14 requested a review from alfonsomthd August 31, 2021 05:12

aaSharma14 force-pushed the add-osd-cluster-creation branch from 35c5aae to 4a721eb Compare August 31, 2021 09:17

mgr/dashboard: Cluster Creation Create OSDs Section

223c91a

Create OSDs section in cluster creation wizard Fixes: https://tracker.ceph.com/issues/51991 Signed-off-by: Aashish Sharma <aasharma@redhat.com>

nizamial09 force-pushed the add-osd-cluster-creation branch from 4a721eb to 223c91a Compare August 31, 2021 12:16

Dashboard automation moved this from Review in progress to Reviewer approved Sep 1, 2021

aaSharma14 moved this from Reviewer approved to Ready-to-merge in Dashboard Sep 1, 2021

epuertat merged commit 9f50cb1 into ceph:feature-50336-cluster-creation-wizard Sep 1, 2021

Dashboard automation moved this from Ready-to-merge to Done Sep 1, 2021

epuertat deleted the add-osd-cluster-creation branch September 1, 2021 10:26

epuertat added the feature label Feb 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mgr/dashboard: Create OSDs section in cluster creation wizard #42583

mgr/dashboard: Create OSDs section in cluster creation wizard #42583

aaSharma14 commented Aug 2, 2021 •

edited

aaSharma14 commented Aug 6, 2021

nizamial09 left a comment

aaSharma14 commented Aug 9, 2021

aaSharma14 commented Aug 9, 2021

votdev left a comment •

edited

votdev Aug 9, 2021

alfonsomthd Aug 12, 2021

nizamial09 commented Aug 17, 2021 •

edited

nizamial09 left a comment

avanthakkar Aug 30, 2021

avanthakkar Aug 30, 2021 •

edited

nizamial09 Aug 30, 2021 •

edited

nizamial09 Aug 30, 2021

avanthakkar Aug 30, 2021

pereman2 left a comment

avanthakkar left a comment

nizamial09 commented Aug 30, 2021

nizamial09 commented Aug 31, 2021

avanthakkar commented Aug 31, 2021

aaSharma14 commented Aug 31, 2021

nizamial09 commented Aug 31, 2021

nizamial09 commented Aug 31, 2021 •

edited

mgr/dashboard: Create OSDs section in cluster creation wizard #42583

mgr/dashboard: Create OSDs section in cluster creation wizard #42583

Conversation

aaSharma14 commented Aug 2, 2021 • edited

aaSharma14 commented Aug 6, 2021

nizamial09 left a comment

Choose a reason for hiding this comment

aaSharma14 commented Aug 9, 2021

aaSharma14 commented Aug 9, 2021

votdev left a comment • edited

Choose a reason for hiding this comment

votdev Aug 9, 2021

Choose a reason for hiding this comment

alfonsomthd Aug 12, 2021

Choose a reason for hiding this comment

nizamial09 commented Aug 17, 2021 • edited

nizamial09 left a comment

Choose a reason for hiding this comment

avanthakkar Aug 30, 2021

Choose a reason for hiding this comment

avanthakkar Aug 30, 2021 • edited

Choose a reason for hiding this comment

nizamial09 Aug 30, 2021 • edited

Choose a reason for hiding this comment

nizamial09 Aug 30, 2021

Choose a reason for hiding this comment

avanthakkar Aug 30, 2021

Choose a reason for hiding this comment

pereman2 left a comment

Choose a reason for hiding this comment

avanthakkar left a comment

Choose a reason for hiding this comment

nizamial09 commented Aug 30, 2021

nizamial09 commented Aug 31, 2021

avanthakkar commented Aug 31, 2021

aaSharma14 commented Aug 31, 2021

nizamial09 commented Aug 31, 2021

nizamial09 commented Aug 31, 2021 • edited

aaSharma14 commented Aug 2, 2021 •

edited

votdev left a comment •

edited

nizamial09 commented Aug 17, 2021 •

edited

avanthakkar Aug 30, 2021 •

edited

nizamial09 Aug 30, 2021 •

edited

nizamial09 commented Aug 31, 2021 •

edited