cephadm: add --container-cli-args parameter #42671
Conversation
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
guits
force-pushed
the
guits-container-extra-opts
branch
from
6fbc0fe
to
2371fd3
Compare
guits
force-pushed
the
guits-container-extra-opts
branch
from
2371fd3
to
c09c797
Compare
|
jenkins test make check |
guits
force-pushed
the
guits-container-extra-opts
branch
from
c09c797
to
a678e15
Compare
There was a problem hiding this comment.
this all looks goods and is working as expected. you can pass a flag into bootstrap and it will add that flag to all unit.run file so the podman run uses that flag. the original problem you tried to solve in #42521 doesnt seemed to be solved though. podman run has no verrify-tls flag that i could figure out. so although this is all good and functional you still dont have a way to pull images from http.
That's why I opened containers/podman#11129 @Daniel-Pivonka |
|
See sebastian-philipp/registries-conf-ctl#6 for an alternative to this one |
guits
changed the title
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
guits
force-pushed
the
guits-container-extra-opts
branch
from
a678e15
to
b9e7209
Compare
guits
force-pushed
the
guits-container-extra-opts
branch
from
b9e7209
to
4c2d49d
Compare
|
jenkins test dashboard cephadm |
guits
force-pushed
the
guits-container-extra-opts
branch
4 times, most recently
from
e43fe2b
to
99cf1f9
Compare
|
jenkins test make check |
guits
force-pushed
the
guits-container-extra-opts
branch
from
99cf1f9
to
b6bf048
Compare
| parser_deploy.add_argument( | ||
| '--allow-ptrace', | ||
| action='store_true', | ||
| help='Allow SYS_PTRACE on daemon container') |
There was a problem hiding this comment.
This removes an option (--allow-ptrace) without deprecating it. If we cherry-pick this to pacific, it will destabilize users who might have relied on this.
What if you changed this to help=argparse.SUPPRESS and printed a warning to the user instead?
There was a problem hiding this comment.
@ktdreyer do you suggest I should drop this commit entirely?
There was a problem hiding this comment.
I think it's ok to drop it in Ceph's Quincy release.
If you're cherry-picking this change to the pacific branch, it's a good idea to not cherry-pick this removal to that stable branch. For example, I think Red Hat has existing documentation that refers to --allow-ptrace right?
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
So we can add any extra parameters to any calls to `podman run` executed by cephadm. Fixes: https://tracker.ceph.com/issues/52065 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
`--container_cli_args` which is more generic allows to set that kind of parameter. Since there's no need to have a dedicated option for this, let's drop this one. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
guits-container-extra-opts
branch
from
b6bf048
to
5098b26
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
So we can add any extra parameters to any calls to
podman runexecutedby cephadm.
Fixes: https://tracker.ceph.com/issues/52065
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com