Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: don't notify for suppressed alerts #42768

Merged
merged 1 commit into from Aug 18, 2021
Merged

mgr/dashboard: don't notify for suppressed alerts #42768

merged 1 commit into from Aug 18, 2021

Conversation

s0nea
Copy link
Member

@s0nea s0nea commented Aug 12, 2021 •
edited

Fixes: https://tracker.ceph.com/issues/51987
Signed-off-by: Tatjana Dehler tdehler@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

mgr/dashboard: don't notify for suppressed alerts
e9f316d 
Fixes: https://tracker.ceph.com/issues/51987
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
@s0nea s0nea requested review from p-se and aaSharma14 August 12, 2021 14:12
@s0nea s0nea requested a review from a team as a code owner August 12, 2021 14:12
@s0nea s0nea added this to In progress in Dashboard via automation Aug 12, 2021
@s0nea s0nea requested review from aaryanporwal and removed request for a team August 12, 2021 14:12
@alfonsomthd alfonsomthd added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Aug 17, 2021
Dashboard automation moved this from In progress to Reviewer approved Aug 17, 2021
avanthakkar
avanthakkar approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Aug 17, 2021
Dashboard automation moved this from Ready-to-merge to Reviewer approved Aug 17, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Aug 17, 2021
pereman2
pereman2 approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@pereman2 pereman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and working fine 👍

Dashboard automation moved this from Ready-to-merge to Reviewer approved Aug 17, 2021
@nizamial09 nizamial09 moved this from Reviewer approved to Ready-to-merge in Dashboard Aug 17, 2021
@alfonsomthd alfonsomthd merged commit 6d7dfef into ceph:master Aug 18, 2021
Dashboard automation moved this from Ready-to-merge to Done Aug 18, 2021
@s0nea s0nea mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@pereman2 pereman2 pereman2 approved these changes

@Waadkh7 Waadkh7 Waadkh7 approved these changes

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@p-se p-se Awaiting requested review from p-se

@aaryanporwal aaryanporwal Awaiting requested review from aaryanporwal

Assignees
No one assigned
Labels
bug-fix dashboard monitoring pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
7 participants
@s0nea @alfonsomthd @avanthakkar @pereman2 @Waadkh7 @aaSharma14 @nizamial09